Closed Bug 1533418 Opened 5 years ago Closed 5 years ago

The sources tree should be keyboard navigable

Categories

(DevTools :: Debugger, defect, P2)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox68 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: jlast, Assigned: davidwalsh)

References

Details

(Whiteboard: [debugger-mvp])

Attachments

(1 file, 1 obsolete file)

Bug 1533418 - Support multiple workers as roots. r=davidwalsh
47 bytes, text/x-phabricator-request
Details | Review

We should use one Tree for all of the threads, which would improve arrow keys, tabs, and scrolling...

Priority: -- → P2
Assignee: nobody → dwalsh
Target Milestone: --- → Firefox 68

http://dbg-workers.glitch.me

Updated tests in SourcesTree.spec.js to pass and
added test to ensure sources are added to the correct thread

Attachment #9058448 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6bd85479233a
Support multiple workers as roots. r=jlast

Backed out changeset 6bd85479233a (Bug 1533418) for browser_browser_toolbox_debugger.js and browser_toolbox_view_source_03.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Ctest-linux64-asan%2Fopt-mochitest-devtools-chrome-e10s-&fromchange=4d5a0aca43c2f8303078cdc003848ce4930c6b10&tochange=7a987cb301d52b6207de900e91973d16ffa2f086&selectedJob=245161069

Backout link: https://hg.mozilla.org/integration/autoland/rev/7a987cb301d52b6207de900e91973d16ffa2f086

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245161069&repo=autoland&lineNumber=2248

task 2019-05-07T17:31:54.686Z] 17:31:54 INFO - TEST-START | devtools/client/framework/test/browser_browser_toolbox_debugger.js
[task 2019-05-07T17:31:54.843Z] 17:31:54 INFO - GECKO(1415) | Debugger Server for Browser Toolbox listening on port: 35832
[task 2019-05-07T17:31:55.776Z] 17:31:55 INFO - GECKO(1415) | 1557250315766 Marionette TRACE Received observer notification profile-after-change
[task 2019-05-07T17:31:55.933Z] 17:31:55 INFO - GECKO(1415) | 1557250315925 Marionette TRACE Received observer notification command-line-startup
[task 2019-05-07T17:31:56.143Z] 17:31:56 INFO - GECKO(1415) | 1557250316135 Marionette TRACE Received observer notification toplevel-window-ready
[task 2019-05-07T17:32:02.659Z] 17:32:02 INFO - GECKO(1415) | console.log: ({type:"ADD_SOURCES", cx:{navigateCounter:0}, sources:[{id:"sourceURL-chrome://global/content/bindings/textbox.xml", url:"chrome://global/content/bindings/textbox.xml", relativeUrl:"chrome://global/content/bindings/textbox.xml", isPrettyPrinted:false, sourceMapURL:null, introductionUrl:null, introductionType:(void 0), isBlackBoxed:false, isWasm:false, isExtension:false}]}) ""
...
[task 2019-05-07T17:32:03.856Z] 17:32:03 INFO - GECKO(1415) | console.log: ({type:"ADD_SOURCES", cx:{navigateCounter:0}, sources:[]}) ""
[task 2019-05-07T17:32:03.856Z] 17:32:03 INFO - GECKO(1415) | console.log: ({type:"INSERT_SOURCE_ACTORS", items:[]}) ""
[task 2019-05-07T17:32:04.356Z] 17:32:04 INFO - GECKO(1415) | console.log: ({type:"SET_EXPANDED_STATE", expanded:{}}) ""
[task 2019-05-07T17:32:04.372Z] 17:32:04 INFO - GECKO(1415) | console.log: ({type:"SET_ORIENTATION", orientation:"horizontal"}) ""
[task 2019-05-07T17:32:04.792Z] 17:32:04 INFO - GECKO(1415) | START: 2086
[task 2019-05-07T17:32:04.794Z] 17:32:04 INFO - GECKO(1415) | Waiting for debugger load
[task 2019-05-07T17:32:04.838Z] 17:32:04 INFO - GECKO(1415) | Waiting on sources: http://mozilla.org/browser-toolbox-test-1557250314726.js
[task 2019-05-07T17:32:04.845Z] 17:32:04 INFO - GECKO(1415) | Finished waiting on sources: http://mozilla.org/browser-toolbox-test-1557250314726.js
[task 2019-05-07T17:32:04.849Z] 17:32:04 INFO - GECKO(1415) | Loaded, selecting the test script to debug
[task 2019-05-07T17:32:05.027Z] 17:32:05 INFO - GECKO(1415) | JavaScript error: chrome://devtools/content/framework/toolbox-process-window.js, line 2106: TypeError: domain is undefined
[task 2019-05-07T17:35:49.769Z] 17:35:49 INFO - GECKO(1415) | console.log: ({type:"ADD_SOURCES", cx:{navigateCounter:0}, sources:[{id:"sourceURL-resource://services-settings/RemoteSettingsComponents.jsm", url:"resource://services-settings/RemoteSettingsComponents.jsm", relativeUrl:"resource://services-settings/RemoteSettingsComponents.jsm", isPrettyPrinted:false, sourceMapURL:null, introductionUrl:null, introductionType:(void 0), isBlackBoxed:false, isWasm:false, isExtension:false}]}) ""
[task 2019-05-07T17:35:49.846Z] 17:35:49 INFO - GECKO(1415) | console.log: ({type:"SET_EXPANDED_STATE", expanded:{}}) ""
[task 2019-05-07T17:35:49.989Z] 17:35:49 INFO - GECKO(1415) | console.log: ({type:"INSERT_SOURCE_ACTORS", items:[{id:"server3.conn0.source1087", actor:"server3.conn0.source1087", thread:"server3.conn0.context18", source:"sourceURL-resource://services-settings/RemoteSettingsComponents.jsm", isBlackBoxed:false, sourceMapURL:null, url:"resource://services-settings/RemoteSettingsComponents.jsm", introductionUrl:null, introductionType:(void 0)}]}) ""
[task 2019-05-07T17:35:50.045Z] 17:35:50 INFO - GECKO(1415) | console.log: ({type:"SET_EXPANDED_STATE", expanded:{}}) ""
[task 2019-05-07T17:35:50.122Z] 17:35:50 INFO - GECKO(1415) | console.log: ({type:"ADD_SOURCES", cx:{navigateCounter:0}, sources:[{id:"sourceURL-resource://services-common/uptake-telemetry.js", url:"resource://services-common/uptake-telemetry.js", relativeUrl:"resource://services-common/uptake-telemetry.js", isPrettyPrinted:false, sourceMapURL:null, introductionUrl:null, introductionType:(void 0), isBlackBoxed:false, isWasm:false, isExtension:false}]}) ""
[task 2019-05-07T17:35:50.158Z] 17:35:50 INFO - GECKO(1415) | console.log: ({type:"SET_EXPANDED_STATE", expanded:{}}) ""
[task 2019-05-07T17:35:50.200Z] 17:35:50 INFO - GECKO(1415) | console.log: ({type:"INSERT_SOURCE_ACTORS", items:[{id:"server3.conn0.source1102", actor:"server3.conn0.source1102", thread:"server3.conn0.context18", source:"sourceURL-resource://services-common/uptake-telemetry.js", isBlackBoxed:false, sourceMapURL:null, url:"resource://services-common/uptake-telemetry.js", introductionUrl:null, introductionType:(void 0)}]}) ""
[task 2019-05-07T17:35:50.236Z] 17:35:50 INFO - GECKO(1415) | console.log: ({type:"SET_EXPANDED_STATE", expanded:{}}) ""
[task 2019-05-07T17:37:54.715Z] 17:37:54 INFO - TEST-INFO | started process screentopng
[task 2019-05-07T17:37:55.060Z] 17:37:55 INFO - TEST-INFO | screentopng: exit 0
[task 2019-05-07T17:37:55.061Z] 17:37:55 INFO - Buffered messages logged at 17:31:54
[task 2019-05-07T17:37:55.061Z] 17:37:55 INFO - Entering test bound runTest
[task 2019-05-07T17:37:55.062Z] 17:37:55 INFO - Opening the browser toolbox
[task 2019-05-07T17:37:55.062Z] 17:37:55 INFO -
[task 2019-05-07T17:37:55.062Z] 17:37:55 INFO - TEST-PASS | devtools/client/framework/test/browser_browser_toolbox_debugger.js | Browser toolbox started
[task 2019-05-07T17:37:55.062Z] 17:37:55 INFO - -
[task 2019-05-07T17:37:55.063Z] 17:37:55 INFO - Buffered messages logged at 17:33:24
[task 2019-05-07T17:37:55.063Z] 17:37:55 INFO - Longer timeout required, waiting longer... Remaining timeouts: 3
[task 2019-05-07T17:37:55.063Z] 17:37:55 INFO - Buffered messages logged at 17:34:54
[task 2019-05-07T17:37:55.065Z] 17:37:55 INFO - Longer timeout required, waiting longer... Remaining timeouts: 2
[task 2019-05-07T17:37:55.065Z] 17:37:55 INFO - Buffered messages logged at 17:35:49
[task 2019-05-07T17:37:55.065Z] 17:37:55 INFO - Console message: [JavaScript Error: "Polling for changes failed: Unexpected content-type "text/html;charset=utf-8"." {file: "resource://services-settings/remote-settings.js" line: 208}]
[task 2019-05-07T17:37:55.065Z] 17:37:55 INFO - remoteSettingsFunction/remoteSettings.pollChanges@resource://services-settings/remote-settings.js:208:13
[task 2019-05-07T17:37:55.065Z] 17:37:55 INFO - async*notify@resource://services-settings/RemoteSettingsComponents.jsm:22:20
[task 2019-05-07T17:37:55.066Z] 17:37:55 INFO - TM_notify/<@resource://gre/modules/UpdateTimerManager.jsm:192:48
[task 2019-05-07T17:37:55.067Z] 17:37:55 INFO - TM_notify@resource://gre/modules/UpdateTimerManager.jsm:239:7
[task 2019-05-07T17:37:55.067Z] 17:37:55 INFO -
[task 2019-05-07T17:37:55.068Z] 17:37:55 INFO - Buffered messages logged at 17:36:24
[task 2019-05-07T17:37:55.069Z] 17:37:55 INFO - Longer timeout required, waiting longer... Remaining timeouts: 1
[task 2019-05-07T17:37:55.069Z] 17:37:55 INFO - Buffered messages finished
[task 2019-05-07T17:37:55.069Z] 17:37:55 INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_browser_toolbox_debugger.js | Test timed out -
[task 2019-05-07T17:37:55.070Z] 17:37:55 INFO - GECKO(1415) | MEMORY STAT | vsize 20974961MB | residentFast 1142MB
[task 2019-05-07T17:37:55.070Z] 17:37:55 INFO - TEST-OK | devtools/client/framework/test/browser_browser_toolbox_debugger.js | took 360059ms
...
[task 2019-05-07T17:51:21.272Z] 17:51:21 INFO - Buffered messages logged at 17:49:51
[task 2019-05-07T17:51:21.273Z] 17:51:21 INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/framework/test/doc_viewsource.html
[task 2019-05-07T17:51:21.275Z] 17:51:21 INFO - Tab added and finished loading
[task 2019-05-07T17:51:21.276Z] 17:51:21 INFO - Opening the toolbox
[task 2019-05-07T17:51:21.281Z] 17:51:21 INFO - Buffered messages logged at 17:49:53
[task 2019-05-07T17:51:21.282Z] 17:51:21 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/Breakpoint.js" line: 29}]
[task 2019-05-07T17:51:21.283Z] 17:51:21 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/Breakpoint.js" line: 29}]
[task 2019-05-07T17:51:21.284Z] 17:51:21 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/Breakpoint.js" line: 29}]
[task 2019-05-07T17:51:21.288Z] 17:51:21 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/Breakpoint.js" line: 29}]
[task 2019-05-07T17:51:21.289Z] 17:51:21 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/ColumnBreakpoint.js" line: 26}]
[task 2019-05-07T17:51:21.290Z] 17:51:21 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/ColumnBreakpoint.js" line: 26}]
[task 2019-05-07T17:51:21.291Z] 17:51:21 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/ColumnBreakpoint.js" line: 26}]
[task 2019-05-07T17:51:21.291Z] 17:51:21 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/ColumnBreakpoint.js" line: 26}]
[task 2019-05-07T17:51:21.293Z] 17:51:21 INFO - Buffered messages logged at 17:49:55
[task 2019-05-07T17:51:21.293Z] 17:51:21 INFO - Toolbox opened and focused
[task 2019-05-07T17:51:21.294Z] 17:51:21 INFO - Buffered messages logged at 17:49:56
[task 2019-05-07T17:51:21.296Z] 17:51:21 INFO - Console message: [JavaScript Warning: "Use of nsIFile in content process is deprecated." {file: "resource://gre/modules/NetUtil.jsm" line: 245}]
[task 2019-05-07T17:51:21.297Z] 17:51:21 INFO - Buffered messages finished
[task 2019-05-07T17:51:21.298Z] 17:51:21 INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_toolbox_view_source_03.js | Test timed out -
[task 2019-05-07T17:51:21.443Z] 17:51:21 INFO - GECKO(1415) | console.log: ({type:"ADD_SOURCES", cx:{navigateCounter:0}, sources:[]}) ""
[task 2019-05-07T17:51:21.552Z] 17:51:21 INFO - GECKO(1415) | console.log: ({type:"INSERT_SOURCE_ACTORS", items:[{id:"server3.conn0.source13127", actor:"server3.conn0.source13127", thread:"server3.conn0.context18", source:"sourceURL-resource://devtools/client/debugger/src/utils/connect.js", isBlackBoxed:false, sourceMapURL:null, url:"resource://devtools/client/debugger/src/utils/connect.js", introductionUrl:null, introductionType:(void 0)}]}) ""
[task 2019-05-07T17:51:21.553Z] 17:51:21 INFO - GECKO(1415) | console.log: ({type:"SET_EXPANDED_STATE", expanded:{}}) ""
[task 2019-05-07T17:51:21.554Z] 17:51:21 INFO - GECKO(1415) | console.log: ({type:"ADD_SOURCES", cx:{navigateCounter:0}, sources:[]}) ""
[task 2019-05-07T17:51:21.556Z] 17:51:21 INFO - GECKO(1415) | console.log: ({type:"INSERT_SOURCE_ACTORS", items:[{id:"server3.conn0.source13128", actor:"server3.conn0.source13128", thread:"server3.conn0.context18", source:"sourceURL-resource://devtools/client/debugger/src/actions/index.js", isBlackBoxed:false, sourceMapURL:null, url:"resource://devtools/client/debugger/src/actions/index.js", introductionUrl:null, introductionType:(void 0)}]}) ""
[task 2019-05-07T17:51:21.595Z] 17:51:21 INFO - GECKO(1415) | console.log: ({type:"SET_EXPANDED_STATE", expanded:{}}) ""
[task 2019-05-07T17:51:21.596Z] 17:51:21 INFO - GECKO(1415) | console.log: ({type:"ADD_SOURCES", cx:{navigateCounter:0}, sources:[]}) ""
[task 2019-05-07T17:51:21.695Z] 17:51:21 INFO - GECKO(1415) | console.warn: "Error while detaching the thread front: 'detach' request packet to 'server1.conn12.child1/context18' can't be sent as the connection is closed."
[task 2019-05-07T17:51:27.687Z] 17:51:27 INFO - Removing tab.
[task 2019-05-07T17:51:27.688Z] 17:51:27 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2019-05-07T17:51:27.729Z] 17:51:27 INFO - Got event: 'TabClose' on [object XULElement].
[task 2019-05-07T17:51:27.759Z] 17:51:27 INFO - Tab removed and finished closing

Type: enhancement → defect
Flags: needinfo?(dwalsh)
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51988a2d186a
Support multiple workers as roots. r=jlast
Whiteboard: [debugger-mvp]

https://hg.mozilla.org/mozilla-central/rev/51988a2d186a

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Flags: needinfo?(dwalsh)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: