1533421 - Vertical Tabs Reloaded causes constant shader recompilation

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Patrick Walton (:pcwalton)]

Every few seconds, over the past few days, WebRender has been recompiling shaders, causing noticeable hiccups. I don't believe it was doing so before. (I verified that it's shader compilation through the profiler.)

I haven't yet dug into why it's doing that.

Comment 1

[Patrick Walton (:pcwalton)]

Here's a profile: https://perfht.ml/2CaWn4f

Comment 2

[Markus Stange [:mstange]]

I see createBrowser from resource:///modules/ExtensionPopups.jsm in that profile. Maybe some invisible add-on panel is frequently recreating itself?

Comment 3

[Patrick Walton (:pcwalton)]

(In reply to Markus Stange [:mstange] from comment #2)

I see createBrowser from resource:///modules/ExtensionPopups.jsm in that profile. Maybe some invisible add-on panel is frequently recreating itself?

Aha, it's Vertical Tabs Reloaded. Disabling it fixes the issue. So I suppose the fix is to move to Core Animation so we can share GL contexts between windows.

Should I keep this open?

Comment 4

[Markus Stange [:mstange]]

Yeah, let's keep it open.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

This should be fixed by context sharing.