1533422 - Crash in [@ libpkcs11-dnietif.so@0xb364]

Status: REOPENED

(External Software Affecting Firefox :: Other, defect, P3)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-941a9a81-71a6-49f7-b4a9-715e30190307.

Seen while looking at 65 release crash stats: https://bit.ly/2VOabt1. Although not new to 65, this signature seems to have risen over time and is at the top of Mac specific crashes in 65.0.2. Lots of the comments are from users in the ES-ES locale.

Comments:

• Mozilla has closed suddenly on my MacBook Pro (mid 2014) with macOS X v. 10.14.3 (Mojave) when trying to login with my DNIe
• working with smart card reader

Top 10 frames of crashing thread:

0 libpkcs11-dnietif.so libpkcs11-dnietif.so@0xb364 
1 libpkcs11-dnietif.so libpkcs11-dnietif.so@0x2e8c0 
2 libpkcs11-dnietif.so libpkcs11-dnietif.so@0x3794 
3 libpkcs11-dnietif.so libpkcs11-dnietif.so@0x2e38e 
4 libpkcs11-dnietif.so libpkcs11-dnietif.so@0x11825 
5 libpkcs11-dnietif.so libpkcs11-dnietif.so@0x115cb 
6 libpkcs11-dnietif.so libpkcs11-dnietif.so@0x2fa13 
7 libnss3.dylib PK11_GetTokenInfo security/nss/lib/pk11wrap/pk11slot.c:1855
8 XUL nsPK11Token::refreshTokenInfo security/manager/ssl/nsPK11TokenDB.cpp:56
9 XUL nsNSSCertificate::GetTokenName security/manager/ssl/nsPK11TokenDB.cpp:25

Comment 1

[Marcia Knous [:marcia]]

Ruben and Isabel - Do either of you use a DNIe and a Mac, and if so are you crashing? Thanks in advance.

Comment 2

[Rubén Martín [:Nukeador] ❌ [away till Aug 31st]]

Sorry I don't use the DNIe or a Mac.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Another PKCS#11 module crash. We probably need to determine the company responsible for this module and contact them.

Comment 4

[Isabel Rios[:isabel_rios]]

I don't use it in a regular basis but I have it and a mac, I don't have a smart scan though but I will get one...
I'm not very familiar with those crash reports, trying to understand the steps for reproducing the bug, is there anything I should do specifically?
Any info about the smart scan used? is it always the same model?
Thanks!

Comment 5

[Marcia Knous [:marcia]]

Isabel: There are some comments in the crash reports but I don't think we have exact STR. Mac 10.14, 10.13 and 10.12 are affected. Most of the users are on the release channel and are using 65.x. Here are some of the comments:

• I installed the electronic din and put the password and restart firefox and it gives me the notice to re-enter the password
• I'm trying to install digital certificates from the DNIe and the browser closes

Comment 6

[Isabel Rios[:isabel_rios]]

Attachment: Screenshot 2019-03-11 at 11.46.45.png

Comment 7

[Isabel Rios[:isabel_rios]]

Attachment: LogsCrashFirefoxClosingTabs.rtf

Comment 8

[Isabel Rios[:isabel_rios]]

Marcia, I think I was able to reproduce the crash.
These are the steps:
-Install dnie
-With the smart card and the dnie in it close all tabs
-Close firefox

Then the message attached is shown, logs attached too.

Please let me know how I can help to debug this issue further if it looks like the one reported.
Thanks!

Comment 9

[Marcia Knous [:marcia]]

Thanks very much Isabel. Dana - How do we find out the company responsible for the module? Thanks.

Comment 10

[Isabel Rios[:isabel_rios]]

Let me know if you need more info about the smart scan, this is Coolbox and has a serial number...

Comment 11

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Looks like maybe https://www.dnielectronico.es/PortalDNIe/ ?

Comment 12

[Isabel Rios[:isabel_rios]]

That's the national police website which is where you go to get your DNIe and passport but not sure they are responsible for the module. I can see there is a technical office support contact where you can send an email, that might be a good site to ask: [e-mail]

Comment 13

[Marcia Knous [:marcia]]

(In reply to Isabel Rios[:isabel_rios] from comment #12)

That's the national police website which is where you go to get your DNIe and passport but not sure they are responsible for the module. I can see there is a technical office support contact where you can send an email, that might be a good site to ask: [e-mail]

We probably need someone who speaks Spanish to help here especially for any outreach - but I think we need to understand exactly what we need to ask for. I don't know much about DNIe and how it works.

Comment 14

[Mike Taylor [:miketaylr]]

Dana, if we get in touch with the site, do we have more info for them? Do we understand the crash? Not sure what's typical or useful in cases like these.

Comment 15

[Dana Keeler (she/her) (use needinfo) [:keeler]]

From what I can tell, their PKCS#11 module (basically a third-party library that gets loaded into Firefox's memory space) crashes when Firefox calls various functions the module is supposed to implement (so far I've seen C_GetSlotInfo, C_GetTokenInfo, C_CloseSession, and C_CloseAllSessions).

Comment 16

[Isabel Rios[:isabel_rios]]

(In reply to Marcia Knous [:marcia - needinfo? me] from comment #13)

We probably need someone who speaks Spanish to help here especially for any outreach - but I think we need to understand exactly what we need to ask for. I don't know much about DNIe and how it works.

Let me know if you need help from my side on this or anything else I could do...Thanks

Comment 17

[Marcia Knous [:marcia]]

Adding 68 as affected. Still a relatively small volume crash on 66.

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:marcia, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 19

[Patricia Lawless]

Bulk change of P3 carryover bugs to wontfix for 68.

Comment 20

[Marcia Knous [:marcia]]

I was asked for an update regarding this bug at the All hands. We are still having crashes, but in small volume. Until or unless the volume increases, I assume this will remain a low priority bug.

Comment 21

[Dana Keeler (she/her) (use needinfo) [:keeler]]

In this case, 3rd party code is crashing. Since that code is loaded in Firefox's process space, it causes Firefox to crash. We can't directly fix it, but something like bug 1396030 would at least mitigate the issue. That's a lot of work and we're a long way from shipping it, unfortunately. I suppose we could at least inform the user that loading this module may cause Firefox to be unstable, but that's more of a product/front-end decision.

Comment 22

[Liz Henry (:lizzard) (relman/hg->git project)]

Happy to take a patch for 70 but since this is triaged and set to P3 priority I'm setting it as fix-optional.
That will remove the bug from weekly regression triage.

Comment 23

[Steven Michaud [:smichaud] (Retired)]

These crashes are still happening, almost entirely in the es-ES locale. As noted above, they're associated with use of the Spanish government's "DNIe" -- an "electronic" equivalent of the Spanish national identity card. After some digging around, I found a page from which to download current versions of the module that's crashing:

https://www.dnielectronico.es/PortalDNIe/PRF1_Cons02.action?pag=REF_1113

After running the installer for one of these, it brings up a page of instructions (in Spanish) on (among other things) how to load the libpkcs11-dnietif.so driver (which you've just installed) into Firefox as a "security device".

I'm not sure, though, how you'd go about triggering this bug's crashes without actually possessing a Spanish "electronic national identity card".

Someone from Mozilla should try contacting the Cuerpo Nacional de Policía (https://www.dnielectronico.es).

Comment 24

[Steven Michaud [:smichaud] (Retired)]

As best I can tell, the email address for the Servicio de Atención al Usuario del DNI/DNI User Support Service is [e-mail].

https://support.mozilla.org/en-US/questions/1249821
https://www.dnielectronico.es/PortalDNIe/PRF1_Cons02.action?pag=REF_2110&id_menu=41

Comment 25

[BugBot [:suhaib / :marco/ :calixte]]

Since the crash volume is low (less than 15 per week), the severity is downgraded to S3. Feel free to change it back if you think the bug is still critical.

For more information, please visit auto_nag documentation.

Comment 26

[Pascal Chevrel:pascalc]

Although the volume is low, it affects only Spanish citizens running macOS during a sensitive operation mostly on ESR like creating official documents, paying taxes… so regionally this may be more impacting than it looks. gstoll, is there something we could do to mitigate these crashes? Maybe blocking the loading of outdated modules?

Comment 27

[Steven Michaud [:smichaud] (Retired)]

These crashes happen overwhelmingly on ESR versions of Firefox, and on one very old version of macOS (10.13). That's odd, since there's no reason to think this is a bug in Mozilla code, or an OS bug. At a guess, the crashes happen mostly on "institutional" machines -- ones whose owners strictly control software upgrades, and rarely perform them.

https://crash-stats.mozilla.org/search/?modules_in_stack=~dnie&platform=Mac%20OS%20X&date=%3E%3D2024-01-15T14%3A55%3A00.000Z&date=%3C2024-04-15T14%3A55%3A00.000Z&_facets=signature&_facets=version&_facets=platform_version&_facets=proto_signature&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-platform_version

Comment 28

[Greg Stoll :gstoll]

Unfortunately our options are limited here - we don't have the ability to block libraries on Mac, although bug 1858573 might allow this. We are in the process of reaching out to the DNI User Support Service to see if they can address this.

Comment 29

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.

Comment 30

[Steven Michaud [:smichaud] (Retired)]

This bug still has crashes. Socorro changed how unsymbolicated signatures are recorded.