Open Bug 1533505 Opened 6 years ago Updated 2 years ago

exception in proxy.onRequest does not call onError

Categories

(WebExtensions :: Request Handling, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: mixedpuppy, Unassigned)

References

Details

We should probably call onError in this case.

https://bugzilla.mozilla.org/show_bug.cgi?id=1528873#c1 but pertinent part copied below.

"""
proxy.onRequest listener throws an exception, the fetch proceeds without a proxy, and without calling the proxy.onError listener:

browser.proxy.onError.addListener(error => console.log("proxy error:", error.message));

browser.proxy.onRequest.addListener(
details => {
throw new Error("my error");
return {type: "socks", host: "127.0.0.1", port: 9};
},
{urls: ["<all_urls>"]}
);

fetch("https://www.example.com/", {cache: "no-store"})
.then(resp => console.log("fetch status:", resp.status))
.catch(error => console.log("fetch error:", error.message));
"""

Priority: P2 → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.