1533545 - Malloc contention on WrWorker threads is too high.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

This shows up when profiling https://static.mozilla.com/moco/en-US/images/mozilla_eoy_2013_EN.svg

Comment 1

[Nicolas Silva [:nical]]

Things to try:

• Opt into per-worker-thread arena with jemalloc.
• Lower the thread count from num-cpus to num-cpus - 1 with a maximum of maybe 6 or 8. We get diminishing returns from having many threads due to this contention issue and the per-thread overhead of a few things like managing fonts.
• Recycle the tile pixels.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: This patch mostly fixes the contention

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 1533545 - Limit the number of WebRender Workers to 8. r=kats

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 1533545 - Register thread local arenas in WebRender worker threads. r=jrmuizel

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76927efc43f5
Register thread local arenas in WebRender worker threads. r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0260a2dac6c
Limit the number of WebRender Workers to 8. r=kats

Comment 6

[Oana Pop-Rus]

Backed out for build bustages at build/src/gfx/webrender_bindings/WebRenderAPI.cpp

Push that started the failures:https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=d0260a2dac6c070d654e858965b82b4eb06b0d76&selectedJob=242277680

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242277680&repo=mozilla-inbound&lineNumber=18487

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/968d4ed2e984a65bfb8bd60a9820c4aa45624dd5

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed474f3cbc38
Register thread local arenas in WebRender worker threads. r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/1edf22da902a
Limit the number of WebRender Workers to 8. r=kats

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4615f45cd4fe
Backout because of build bustage on a CLOSED TREE. r=me

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/ed474f3cbc38
https://hg.mozilla.org/mozilla-central/rev/1edf22da902a
https://hg.mozilla.org/mozilla-central/rev/4615f45cd4fe

Comment 10

[Mayank Bansal]

wait, wasnt all these changes backed out in comment 8, and not relanded?

(In reply to Raul Gurzau (:RaulGurzau) from comment #9)

https://hg.mozilla.org/mozilla-central/rev/ed474f3cbc38
https://hg.mozilla.org/mozilla-central/rev/1edf22da902a
https://hg.mozilla.org/mozilla-central/rev/4615f45cd4fe

Isnt the third change the backout of the other two?

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2f7510851a4
Register thread local arenas in WebRender worker threads. r=jrmuizel

Comment 12

[Nicolas Silva [:nical]]

Isnt the third change the backout of the other two?

I had (confusingly) only backed out one of the two commits.

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a2f7510851a4

Comment 14

[Ionuț Goldan [:igoldan]]

Big perf improvements noticed! \0/

== Change summary for alert #20681 (as of Sun, 28 Apr 2019 05:19:44 GMT) ==

Improvements:

25% tsvg_static linux64-shippable-qr opt e10s stylo 59.99 -> 45.28
12% tsvgx linux64-shippable-qr opt e10s stylo 281.98 -> 248.04
10% tsvg_static windows10-64-shippable-qr opt e10s stylo 40.93 -> 36.67
8% tsvgr_opacity linux64-shippable-qr opt e10s stylo 103.70 -> 95.52
6% tsvgx windows10-64-shippable-qr opt e10s stylo 194.91 -> 183.11

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=20681