1533563 - Snap task failing on beta: Missing `snapcraft` module

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Snap, defect)

Description

[Jordan Lund (:jlund)]

https://tools.taskcluster.net/groups/ePchyZ0cSoCcvWGTptYdhQ/tasks/Y-soafXpR-S4K9nKXWcSNw/runs/2/logs/public%2Flogs%2Flive_backing.log

recent snap activity that may be involved: https://bugzilla.mozilla.org/show_bug.cgi?id=1459222

also, given this seems to be a python package configuration issue, could be something puppet related:

aki> i wonder if that's related to https://github.com/mozilla-releng/pushsnapscript/pull/18 at all
13:28:12 (i noticed that pushsnap has conflicting requests version requirements, and unpinning fixes)

Comment 1

[Jordan Lund (:jlund)]

johan, any ideas?

I suspect this doesn't block the release.

Comment 2

[Jordan Lund (:jlund)]

I would have assumed snapcraft to be defined here? https://github.com/mozilla-releng/pushsnapscript/blob/master/requirements.txt

Comment 3

[Aki Sasaki (not active)]

Aiui it's here. It's a weird setup because it's a debian tool running on centos. I imagine once we're running on docker in GCP we can run on ubuntu images, and we'll be able to make this less ugly.

Comment 4

[Johan Lorenzo [:jlorenzo]]

I confirm, it doesn't block the release.

I know what happened. That's a silly error of mine. Like Aki said, the way we package is ugly. You can find more details about why things are this way in bug 1447263 comment 15.
In short: the error is due to me using a new laptop. I forgot to locally clone the git submodule which is (sadly) embedded in the pushsnapscript package. That's why snapcraft (aka the git submodule) is missing.

I agree with Aki, moving to docker will prevent this error from happening again. In the meantime, I'll seize this opportunity to upgrade the packages. It will also address https://github.com/mozilla-releng/pushsnapscript/pull/18

Comment 5

[Johan Lorenzo [:jlorenzo]]

(In reply to Johan Lorenzo [:jlorenzo] from comment #4)

In the meantime, I'll seize this opportunity to upgrade the packages.

Meh, it doesn't work. See https://github.com/mozilla-releng/pushsnapscript/pull/19#issuecomment-470891796 for more details.

Comment 6

[Johan Lorenzo [:jlorenzo]]

Attachment: [pushsnapscript] Bump snapcraft to 3.2

Comment 7

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 9049474 [details] [review]
[pushsnapscript] Bump snapcraft to 3.2

See why it didn't work in comment 5.

Comment 8

[Johan Lorenzo [:jlorenzo]]

Good news. I released the latest beta while debugging this issue: https://tools.taskcluster.net/groups/ePchyZ0cSoCcvWGTptYdhQ/tasks/Y-soafXpR-S4K9nKXWcSNw/runs/4/logs/public%2Flogs%2Flive_backing.log#L134

Comment 9

[Johan Lorenzo [:jlorenzo]]

Attachment: [pushsnapscript] Unpin requests

Patch submitted by Aki.

r+'d by me at https://github.com/mozilla-releng/pushsnapscript/pull/18#pullrequestreview-212237983
Landed on master at https://github.com/mozilla-releng/pushsnapscript/commit/efadd779e6dd63d4b58f14d373dbe6743c921d11
Released as 0.2.6:

• https://pypi.org/project/pushsnapscript/0.2.6/
• https://github.com/mozilla-releng/pushsnapscript/releases/tag/0.2.6

Comment 10

[Johan Lorenzo [:jlorenzo]]

Attachment: [build/puppet] Upgrade pushsnapscript to 0.2.6

Comment 11

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 9049507 [details] [review]
[build/puppet] Upgrade pushsnapscript to 0.2.6

r+'d by mtabara at https://github.com/mozilla-releng/build-puppet/pull/422#pullrequestreview-212276169
Landed on master at https://github.com/mozilla-releng/build-puppet/commit/c0cb221f878a7c26ffa02f35dd51f60fa8f85203