Remove defer usage in devtools/client/shared/widgets/FlameGraph.js

RESOLVED FIXED in Firefox 67

Status

enhancement
P3
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: nchevobbe, Assigned: ivan.menshykov, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

Trunk
Firefox 67

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

2 months ago

We should use new Promise instead.

(Reporter)

Comment 1

2 months ago

Ivan, would you like to work on this bug?

Flags: needinfo?(ivan.menshykov)
(Assignee)

Comment 2

2 months ago

Nicolas, Yes. Please assign me to this bug.

Flags: needinfo?(ivan.menshykov)
(Reporter)

Comment 3

2 months ago

it's yours, thanks!

Assignee: nobody → ivan.menshykov
Status: NEW → ASSIGNED
(Assignee)

Comment 4

2 months ago

Change the defer function with Promise

Attachment #9049505 - Attachment description: Bug 1533658 - Remove defer usage in FlameGraph r=honza → Bug 1533658 - Remove defer usage in FlameGraph r=nicolaso
Attachment #9049505 - Attachment description: Bug 1533658 - Remove defer usage in FlameGraph r=nicolaso → Bug 1533658 - Remove defer usage in FlameGraph. r=nchevobbe.
(Assignee)

Comment 5

2 months ago

Revert the line that was unnecessary deleted

Attachment #9049508 - Attachment description: Address revision issues: revert the line this.SetTheme() → Bug 1533658 - Remove defer usage in FlameGraph. r=nchevobbe.
(Assignee)

Comment 6

2 months ago

Nicolas, I'm sorry. I submit the two patches. I'm trying to update my first patche like describe here: https://docs.firefox-dev.tools/contributing/making-prs.html

I'm not sure what I'm doing wrong.

(Reporter)

Comment 7

2 months ago

No worries :)
Did you amend your first commit?
Are you using arc or moz-phab?

Attachment #9049505 - Attachment is obsolete: true
(Assignee)

Comment 8

2 months ago

Yes, I amended my first commit. And after I did arc diff.

(Reporter)

Comment 9

2 months ago

okay, i think that when doing an update the arc diff command should have other argument, but I don't know arc much. I'm using https://github.com/mozilla-conduit/review, which is really handy for the mozilla workflow and is pretty straightforward.

(Assignee)

Comment 10

2 months ago

OK, Thank you. I will check it.

Comment 11

2 months ago
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/234eea780806
Remove defer usage in FlameGraph. r=nchevobbe.

Comment 12

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.