1533719 - test_getTypeFromExtension_with_empty_Content_Type.js isn't running correctly - originalWindowsRegKeyFactory does not exist

Status: RESOLVED FIXED

(Firefox :: File Handling, enhancement)

Description

[Mark Banner (:standard8)]

In enabling ESLint on uriloader in bug 1532941, we've picked up that in test_getTypeFromExtension_with_empty_Content_Type.js there is an undefined variable originalWindowsRegKeyFactory:

JavaScript error: c:/central/obj-x86_64-pc-mingw32/_tests/xpcshell/uriloader/exthandler/tests/unit/test_getTypeFromExtension_with_empty_Content_Type.js, line 132: ReferenceError: originalWindowsRegKeyFactory is not defined

This means that the mock factory which is registered, never gets created correctly.

Hence, this test isn't running correctly. I've tried fixing it, but then nsIWindowsRegKey.open throws a failure (NS_ERROR_FAILURE).

For now, we'll disable the line in ESLint.

Comment 1

[:Gijs (away/busy until Mar 10)]

bug 568691 broke this in a commit from bsmedberg that doesn't seem to have been reviewed: https://hg.mozilla.org/mozilla-central/rev/d88ae23ecbe7 .

Comment 2

[:Gijs (away/busy until Mar 10)]

Marco has volunteered to take a look. :-)

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1533719 - test_getTypeFromExtension_with_empty_Content_Type.js is not testing what it is supposed to test. r=felipe!

The test was broken by a commit in bug 568691 and because the ".txt" extension
skips the code under test, we never noticed that.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0339d18944be
test_getTypeFromExtension_with_empty_Content_Type.js is not testing what it is supposed to test. r=Felipe

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/0339d18944be