Closed Bug 1533775 Opened 6 years ago Closed 6 years ago

PoisonIOInterposerWin should report the filename when opening non-existant files

Categories

(Core :: Gecko Profiler, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: florian, Assigned: florian)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

A profile like https://perfht.ml/2DRNa0O from bug 1527879 has lots of "create/open" markers without filename. To figure out what was happening I had to debug locally.

It turns out we do have the filename in the interposer at https://searchfox.org/mozilla-central/rev/b2d35912da5b2acecb0274eb113777d344ffb75e/xpcom/build/PoisonIOInterposerWin.cpp#134 but we don't save it because NtPathToDosPath returns false for these paths that don't exist.

Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/63625c423683 PoisonIOInterposerWin should report the filename when opening non-existant files, r=aklotz.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: