PoisonIOInterposerWin should report the filename when opening non-existant files

RESOLVED FIXED in Firefox 67

Status

()

Product:
Core
Component:
Gecko Profiler
Type:
enhancement
Status:
RESOLVED FIXED
Opened:
5 months ago
Updated:
5 months ago

People

(Reporter: florian, Assigned: florian)

Tracking

(Blocks 1 bug)

Version:
unspecified
Target:
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Bug 1533775 - PoisonIOInterposerWin should report the filename when opening non-existant files, r=aklotz.
47 bytes, text/x-phabricator-request
Details | Review

A profile like https://perfht.ml/2DRNa0O from bug 1527879 has lots of "create/open" markers without filename. To figure out what was happening I had to debug locally.

It turns out we do have the filename in the interposer at https://searchfox.org/mozilla-central/rev/b2d35912da5b2acecb0274eb113777d344ffb75e/xpcom/build/PoisonIOInterposerWin.cpp#134 but we don't save it because NtPathToDosPath returns false for these paths that don't exist.

Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63625c423683
PoisonIOInterposerWin should report the filename when opening non-existant files, r=aklotz.

https://hg.mozilla.org/mozilla-central/rev/63625c423683

Status: NEW → RESOLVED
Closed: 5 months ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.