1533879 - Turn off telemetry on geckoview during Raptor tests

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P3)

Description

[Robert Wood [:rwood]]

From an adb logcat taken from a raptor-speedometer-geckoview job it looks like geckoview is trying to ping telemetry:

03-02 15:36:16.132 5653 5669 E GeckoConsole: [JavaScript Error: "1551569776131 Toolkit.Telemetry ERROR TelemetrySend::_doPing - error making request to https://127.0.0.1/telemetry-dummy//submit/telemetry/b6984eae-5c24-4ba6-bd1e-0373f34821e6/health/Fennec/67.0a1/default/20190302214639?v=4: eUnreachable" {file: "resource://gre/modules/Log.jsm" line: 679}]
03-02 15:36:16.132 5653 5669 E GeckoConsole: append@resource://gre/modules/Log.jsm:679:12
03-02 15:36:16.132 5653 5669 E GeckoConsole: log@resource://gre/modules/Log.jsm:360:16
03-02 15:36:16.132 5653 5669 E GeckoConsole: getLoggerWithMessagePrefix/proxy.log@resource://gre/modules/Log.jsm:484:18
03-02 15:36:16.132 5653 5669 E GeckoConsole: error@resource://gre/modules/Log.jsm:368:10
03-02 15:36:16.132 5653 5669 E GeckoConsole: errorhandler@resource://gre/modules/TelemetrySend.jsm:1165:17

We should turn off telemetry (via Firefox prefs) when running Raptor so that it doesn't interfere with the performance tests.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As it looks like we modify the preference to exchange the origin URL with localhost. So at least no telemetry data is getting sent.

I think it's user_pref("toolkit.telemetry.enabled", false); what we want to set in the raptor profile by default.

Raphael, is that still the right pref to turn off telemetry?

Comment 2

[Raphael Aurich [:raphael] UTC+01:00]

We set "datareporting.healthreport.uploadEnabled" to False in the telemetry integration tests, see:
https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/tests/marionette/tests/client/test_deletion_request_ping.py#12

Chutten, can you please confirm that is still the recommended method for disabling telemetry in Firefox?

Comment 3

[Chris H-C :chutten]

That is indeed correct. datareporting.healthreport.uploadEnabled is the pref that coincides with the data choice user setting in `about:preferences#privacy" and is the one button you need to turn off in order to disable Firefox Telemetry (and some other things too).

(on not-Fennec products) toolkit.telemetry.enabled is, due to legacy reasons, locked based on the channels of the build and profile. (the long and complicated documentation of our prefs and what build configs mean which mean what can be found here).

We meant to clean that up after Fennec left on ESR but we unfortunately became busy with other things.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Chris! Florin, to drop the amount of external connections, could one of your team work on that or at least mentor this bug?

Comment 5

[Florin Strugariu [:Bebe]]

Attachment: Bug 1533879 - Turn off telemetry on geckoview during Raptor tests

Comment 6

[Florin Strugariu [:Bebe]]

Added datareporting.healthreport.uploadEnabled : False to all raptor test profiles.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8b664f68228a97c4b37e17b4dea635176afffd8

Comment 7

[Florin Strugariu [:Bebe]]

@whimboo
Ran a mach raptor-test -t raptor-tp6-amazon-firefox --debug locally and took a look over about:config

datareporting.healthreport.uploadEnabled is set to true running mozilla central so it's not set in some other place for our profile.
Offcorse with this patch the pref is set to false

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

No need to set needinfo when you also requested feedback via phabricator some hours ago. I replied there.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa11db74789b
Turn off telemetry on geckoview during Raptor tests r=whimboo,perftest-reviewers,sparky

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/aa11db74789b