1533951 - [Fission] Make network error pages work with Fission

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P3)

Description

[:Felipe Gomes (needinfo for replies!)]

We need these pages working at some basic level for out-of-process iframes.

Comment 1

[Johann Hofmann [:johannh]]

What's currently broken on these pages with fission?

Comment 2

[:Felipe Gomes (needinfo for replies!)]

We haven't checked yet. We agreed on which features would be important for Fission M2 and filed bugs for all of them to track them.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Attachment: Screen Shot 2019-04-23 at 5.25.48 PM.png

I did some testing with Fission enabled and the network error page is already displayed correctly, even in a subframe. It was possible to scroll and focus on the page.

With that, I think that this is enough for a demo-able Fission for M2. Making other interactive features of the error pages work can be pushed out to M3.

Comment 4

[Neha Kochar [:neha]]

Mike, could you please look into the remaining work for this and what would be a good target for it?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Looking.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1533951 - Port NetErrorChild to JS Window Actors. r?johannh

Depends on D33166

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Hi neha,

It looks like there's work underway to refactor a bunch of our network error pages in bug 1544564. That work is slated to be completed in the 69 timeframe, but I don't know if it'll be done by the time Whistler rolls around. I also don't really want to interfere with what's going on in that project by changing the underlying messaging infrastructure. To avoid slowing down both projects, I suggest we wait until bug 1544564 settles, and then we work to make it Fission-compatible.

So I think we should probably punt this to M4.

Comment 8

[Neha Kochar [:neha]]

That makes sense, punting to M4. Thanks mconley.

Comment 9

[Johann Hofmann [:johannh]]

Thanks Mike, please let us know if there's anything we can do to help out!

Comment 10

[Neil Deakin]

Attachment: Bug 1533951, base NetError handler on JSWindowActor, move message listeners out of browser.js and into JSWindowActorParent, r=johannh

Comment 11

[Neil Deakin]

Attachment: Bug 1533951, allow MessagePort to take an actor as well as a message manager. This will allow about pages to be converted to actors yet doesn't require significant changes to messaging, r=mossop

Depends on D51624

Comment 12

[Neil Deakin]

Attachment: Bug 1533951, move network error message listeners to NetErrorParent.jsm, r=mossop

Depends on D51625

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7e3132f1c94
base NetError handler on JSWindowActor, move message listeners out of browser.js and into JSWindowActorParent, r=johannh
https://hg.mozilla.org/integration/autoland/rev/f80dcfac3425
allow MessagePort to take an actor as well as a message manager. This will allow about pages to be converted to actors yet doesn't require significant changes to messaging, r=mossop
https://hg.mozilla.org/integration/autoland/rev/59dcb38e4693
move network error message listeners to NetErrorParent.jsm, r=mossop

Comment 14

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/b7e3132f1c94
https://hg.mozilla.org/mozilla-central/rev/f80dcfac3425
https://hg.mozilla.org/mozilla-central/rev/59dcb38e4693

Comment 15

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello enndeakin. Are there any STR that QA can use to verify this? Thank's!

Comment 16

[Neil Deakin]

You could load to load a page that has a bad certificate in an iframe and then make sure all of the UI elements in the error page work. You can use https://untrusted-root.badssl.com/ as a bad certificate page, but then you would need to host it inside a page on another domain.

That said, this has automated tests already.