Closed Bug 1533951 Opened 1 year ago Closed 4 months ago

[Fission] Make network error pages work with Fission

Categories

(Firefox :: General, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 72
Fission Milestone M5
Tracking Status
firefox72 --- fixed

People

(Reporter: Felipe, Assigned: enndeakin)

References

(Blocks 2 open bugs)

Details

Attachments

(4 files, 1 obsolete file)

We need these pages working at some basic level for out-of-process iframes.

Fission Milestone: --- → M2

What's currently broken on these pages with fission?

We haven't checked yet. We agreed on which features would be important for Fission M2 and filed bugs for all of them to track them.

I did some testing with Fission enabled and the network error page is already displayed correctly, even in a subframe. It was possible to scroll and focus on the page.

With that, I think that this is enough for a demo-able Fission for M2. Making other interactive features of the error pages work can be pushed out to M3.

Fission Milestone: M2 → M3

Mike, could you please look into the remaining work for this and what would be a good target for it?

Flags: needinfo?(mconley)

Looking.

Assignee: nobody → mconley
Flags: needinfo?(mconley)

Hi neha,

It looks like there's work underway to refactor a bunch of our network error pages in bug 1544564. That work is slated to be completed in the 69 timeframe, but I don't know if it'll be done by the time Whistler rolls around. I also don't really want to interfere with what's going on in that project by changing the underlying messaging infrastructure. To avoid slowing down both projects, I suggest we wait until bug 1544564 settles, and then we work to make it Fission-compatible.

So I think we should probably punt this to M4.

Flags: needinfo?(nkochar)

That makes sense, punting to M4. Thanks mconley.

Fission Milestone: M3 → M4
Flags: needinfo?(nkochar)

Thanks Mike, please let us know if there's anything we can do to help out!

Attachment #9068896 - Attachment is obsolete: true
Assignee: mconley → nobody
Fission Milestone: M4 → Future
Attachment #9106186 - Attachment description: Bug 1533951, allow MessagePort to take an actor as well as a message manager. This will allow about pages to be converted to actors yet doesn't require significant changes to messaging, r=johannh → Bug 1533951, allow MessagePort to take an actor as well as a message manager. This will allow about pages to be converted to actors yet doesn't require significant changes to messaging, r=mossop
Attachment #9106187 - Attachment description: Bug 1533951, move network error message listeners to NetErrorParent.jsm, r=johannh → Bug 1533951, move network error message listeners to NetErrorParent.jsm, r=mossop
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b7e3132f1c94
base NetError handler on JSWindowActor, move message listeners out of browser.js and into JSWindowActorParent, r=johannh
https://hg.mozilla.org/integration/autoland/rev/f80dcfac3425
allow MessagePort to take an actor as well as a message manager. This will allow about pages to be converted to actors yet doesn't require significant changes to messaging, r=mossop
https://hg.mozilla.org/integration/autoland/rev/59dcb38e4693
move network error message listeners to NetErrorParent.jsm, r=mossop
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Assignee: nobody → enndeakin
Blocks: 1597228
Fission Milestone: Future → M5

Hello enndeakin. Are there any STR that QA can use to verify this? Thank's!

Flags: needinfo?(enndeakin)

You could load to load a page that has a bad certificate in an iframe and then make sure all of the UI elements in the error page work. You can use https://untrusted-root.badssl.com/ as a bad certificate page, but then you would need to host it inside a page on another domain.

That said, this has automated tests already.

Flags: needinfo?(enndeakin)
You need to log in before you can comment on or make changes to this bug.