1534001 - Add new page title to about:config that doesn't have a appropriate title

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Suriyaa Sundararuban [:suriyaa]]

The about:config site doesn't have an appropriate page title. This bug is based on bug 1051846.

Comment 1

[Suriyaa Sundararuban [:suriyaa]]

Attachment: Add page title to about:config

The about:config site doesn't have an appropriate page title.

Comment 2

[:Paolo Amadini]

See also bug 1533031 comment 9.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10e91ae65552
Add page title to about:config r=Gijs,flod

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c784bea56ea7
Backed out changeset 10e91ae65552 for Browser-Chrome failures in browser/components/aboutconfig/test/browser/browser_basic.js. CLOSED TREE

Comment 5

[Francesco Lodolo [:flod]]

Looks like there are tests that check for a specific text in the title (I'm not a developer, but that doesn't sound like a great test).
https://searchfox.org/mozilla-central/rev/14dc5b7d8a6da1854b2f9f33f1da77a97368cd54/browser/components/aboutconfig/test/browser/browser_basic.js#22

Comment 6

[Suriyaa Sundararuban [:suriyaa]]

@flod True. I updated the Phab revision again.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7b2c2564ead
Add page title to about:config r=Gijs,flod

Comment 8

[Suriyaa Sundararuban [:suriyaa]]

Commit pushed by gijs: https://hg.mozilla.org/integration/autoland/rev/a7b2c2564ead.

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/a7b2c2564ead