1534003 - Update page title in about:buildconfig

Status: VERIFIED FIXED

(Firefox :: General, enhancement)

Description

[Suriyaa Sundararuban [:suriyaa]]

The about:buildconfig site doesn't have an appropriate page title. This bug is based on bug 1051846.

Comment 1

[Suriyaa Sundararuban [:suriyaa]]

Attachment: Update page title in about:buildconfig

Fixes also partially bug 1051846.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc2ae28a117f
Update page title in about:buildconfig r=mconley

Comment 3

[Arthur Iakab [arthur_iakab]]

Backed out changeset dc2ae28a117f (bug 1534003) for causing mochitest failures on test_docload_embedded.html CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/a1e3236f2f5307571e516f55994f8c088ddb204f

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=dc2ae28a117f06e36b1087b037fddb8dbbae63a6&searchStr=mochitest

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=235012995&repo=autoland

mconley can you please take a look?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Hey yzen, do you know what test_docload_embedded.html is trying to do here, and why this test is failing now? I'm having a hard time piecing it together, and why it'd be sensitive to about:buildconfig changes like this. :/

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #4)

Hey yzen, do you know what test_docload_embedded.html is trying to do here, and why this test is failing now? I'm having a hard time piecing it together, and why it'd be sensitive to about:buildconfig changes like this. :/

Looks like we are hardcoding the expected accessible name for the "about:buildconfig" document (essentially the title). It should be fine to change that to the new title value.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Hey yzen,

Does that mean adding another condition here, like we do for about:license?: https://searchfox.org/mozilla-central/rev/7c20ad925005fbad7b8e08813115f1ec7fa1c248/accessible/tests/mochitest/events/docload/test_docload_embedded.html#43

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #6)

Hey yzen,

Does that mean adding another condition here, like we do for about:license?: https://searchfox.org/mozilla-central/rev/7c20ad925005fbad7b8e08813115f1ec7fa1c248/accessible/tests/mochitest/events/docload/test_docload_embedded.html#43

Ah sorry, I should've pointed you there, indeed. I would suggest changing the signature of the changeIframeSrc function to:

function changeIframeSrc(aIdentifier, aURL, aTitle) {
...
            {
              role: ROLE_DOCUMENT,
              name: aTitle,
            },
...
}

and then calling it in the test as:

      gQueue.push(new changeIframeSrc("iframe", "about:license", "Licenses"));
      gQueue.push(new changeIframeSrc("iframe", "about:buildconfig", "Build Configuration"));

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Okay, thanks.

Hi suriyaa! I'm afraid your patch bounced because of a test that I didn't know about that seems to rely on about:buildconfig having a title that matches its URL. yzen has given some advice on how to update the test to be less fragile - see comment 7.

Is that enough information for you to modify the patch?

Comment 9

[Suriyaa Sundararuban [:suriyaa]]

Thanks for the information. I'm working on it.

Comment 10

[Suriyaa Sundararuban [:suriyaa]]

Attachment: Update page title in about:buildconfig

Fixes BMO bug 1534003 and phab commit D22848.

Comment 11

[Suriyaa Sundararuban [:suriyaa]]

Done.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/801b729bae25
Update page title in about:buildconfig r=mconley

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/801b729bae25

Comment 14

[Suriyaa Sundararuban [:suriyaa]]

✅ Commit successfully landed. Thanks.

Comment 15

[Sajedul Islam]

I have reproduced this bug with Nightly 67.0a1 (2019-03-09) Windows 10, 64 Bit !

This bug's fix is Verified with latest Nightly !

• Build ID 20190402083512
• User Agent ::--- Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Comment 16

[Camelia Badau [:cbadau], Desktop QA]

Marking VERIFIED FIXED based on comment 15.