153421 - When throbber is present, closing a window while page is still loading results in crash [@ objc_msgSend]

Status: VERIFIED FIXED

(Camino Graveyard :: Page Layout, defect)

Description

[Chris Petersen]

Build: 2002-06-21-05
Platform: OS X 10.1.5
Expected Result: Window should close with no crash resulting
What I got: Application crashes

Steps to reproduce:

1) Customize toolbar by adding progress throbber (globe).
2) Type a url like cnn.com and press return.
3) Before the page is completely loaded, close it.
4) The application should crash.

Comment 1

[Chris Petersen]

Attachment: Stack trace

Comment 2

[Chris Petersen]

Winnie,

Can you reproduce this ?

Comment 3

[saari (gone)]

adding to the blocker list and tossing at beard incase he has a fix

Comment 4

[Winnie Lam]

Didn't crash for me with 06-21 build.

Comment 5

[Greg K.]

WorksForMe using Chimera/20020621. (Shouldn't this just be critical rather than
blocker?)

Comment 6

[saari (gone)]

I could crash this

Comment 7

[Mike Pinkerton (not reading bugmail)]

i'll take it

Comment 8

[Mike Pinkerton (not reading bugmail)]

the problem here is that we continue loading the page long after the window goes
away. i can't tell why. conrad might be able to tell what we're not doing when
we shut down the machinery.

Comment 9

[Mike Pinkerton (not reading bugmail)]

ok, i figured it out. the throbber's timer was holding a strong ref to the
browser window controller (since it was the target) and keeping it alive long
after the window went away, and as a result, not stopping any pageloads in progress.

i'll fix it, should be pretty simple.

Comment 10

[Mike Pinkerton (not reading bugmail)]

fixed

Comment 11

[Chris Petersen]

Verified fixed in 2002-06-25-05 NB.

Comment 12

[saari (gone)]

*** Bug 154060 has been marked as a duplicate of this bug. ***