The blockautoplay icon isn't show again after switching back to http://arcticmonkeys.com/
Categories
(Firefox :: Site Identity, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox66 | --- | wontfix |
firefox67 | --- | verified |
firefox68 | --- | verified |
People
(Reporter: dcicas, Assigned: daleharvey)
References
Details
(Keywords: regression)
Attachments
(2 files)
7.60 MB,
image/gif
|
Details | |
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
Notes
*I created this bug based on discussions from bug 1526355/#block_autoplay slack channel
Affected versions
- Nightly Fx 67.0a1 BuildID: 20190310214003
Beta Fx 66.0b14
Affected platforms
*Win 10 x64
Win 7 x32
Ubuntu 18.04 LTS
Ubuntu 16.04 LTS
macOS 10.13
Steps to reproduce
Preconditions:
media.autoplay.default = 1
media.autoplay.enabled.user-gestures-needed = true
Open a new window.
Reach https://www.arcticmonkeys.com/
Check the Site Information panel.
Travel to another open tab.
Go back to the arctic monkeys tab.
Expected result
*The block autoplay icon is displayed.
Actual result
*The block autoplay icon is not displayed after returning to the arctic monkeys website.
Additional notes
The Block/Allow options are not displayed when first reaching the Arctic Monkeys website.
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
ok, really not sure what was up with my build but I can reproduce this now
Assignee | ||
Comment 2•6 years ago
|
||
Ok, so its a race condition, the block autoplay message is received before the page has loaded, the progresslistener reports the page loading as a navigation and clears the permission so the next tine the UI is drawn the icon doesnt show
The fix is simple, trying to make a test for it now
Assignee | ||
Comment 3•6 years ago
|
||
Reporter | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Comment 5•6 years ago
|
||
bugherder |
Hi Dale,since 67 is marked as affected, should we consider uplifting this to Beta67? If yes, please nominate a patch for uplift.
Updated•6 years ago
|
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 9051661 [details]
Bug 1534219 - Only clear globally blocked permission on navigation. r=johannh
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: None
- User impact if declined: Icon will not be shown on some sites that have autoplay media blocked
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Described in https://bugzilla.mozilla.org/show_bug.cgi?id=1534219#c0
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small patch with very little chance of regressing
- String changes made/needed:
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Comment 8•6 years ago
|
||
Comment on attachment 9051661 [details]
Bug 1534219 - Only clear globally blocked permission on navigation. r=johannh
FYI, I'll take this patch in beta once it has been verified by QA on Nightly.
Reporter | ||
Comment 9•6 years ago
|
||
Hello,
I verified that this issue is fixed on Nightly Fx 68.0a1 Build Id:20190407214820 for Windows 10 x64, Ubuntu 18.04 and macOS 10.13.
I can confirm this issue is fixed on Nightly.
Comment 10•6 years ago
|
||
Comment on attachment 9051661 [details]
Bug 1534219 - Only clear globally blocked permission on navigation. r=johannh
P1 regression verified by QA on Nightly, uplift approved for 67 beta 10, thanks.
Comment 11•6 years ago
|
||
bugherder uplift |
Reporter | ||
Comment 12•6 years ago
|
||
Hello,
I verified and can confirm that this issue is fixed on Fx 67.0b10 on Windows 10 x64, Ubuntu 18.04 and macOS 10.13.
Description
•