Closed Bug 1534313 Opened 5 years ago Closed 5 years ago

Make the CubebDeviceEnumerator the only path to enumerate audio devices

Categories

(Core :: WebRTC: Audio/Video, enhancement, P2)

66 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: achronop, Assigned: achronop)

References

Details

Attachments

(4 files)

We want that because the CubebDeviceEnumerator contains logic to touch the devices as less as possible on repeating enumerations.

Also, one more patch has been added to move the default output device on the top of the list of output devices, similar to input devices.

Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4252f238b68
Put the default audio output first in the list of devices. r=padenot
https://hg.mozilla.org/integration/autoland/rev/eae4a9ff0b9b
Add new method in enumerator to get the device info from device name. r=padenot
https://hg.mozilla.org/integration/autoland/rev/fc232edfe6e8
Remove direct calls to GetDeviceCollection method. r=padenot
https://hg.mozilla.org/integration/autoland/rev/fe17244230e8
Make GetDeviceCollection accessible only by the enumerator. r=padenot
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4f9968338e4e
Backed out 4 changesets for causing a perfmafailing Gtest in /builds/worker/workspace/build/application/firefox/gmp-clearkey CLOSED TREE
Attachment #9050008 - Attachment description: Bug 1534313 - Put the default audio output first in the list of devices. r?padenot → Bug 1534313 - Put the default audio output first in the list of devices. r=padenot
Attachment #9050009 - Attachment description: Bug 1534313 - Add new method in enumerator to get the device info from device name. r?padenot → Bug 1534313 - Add new method in enumerator to get the device info from device name. r=padenot
Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/383d67dc9870
Put the default audio output first in the list of devices. r=padenot
https://hg.mozilla.org/integration/autoland/rev/a7fb15aa8492
Add new method in enumerator to get the device info from device name. r=padenot
https://hg.mozilla.org/integration/autoland/rev/f6916040dea3
Remove direct calls to GetDeviceCollection method. r=padenot
https://hg.mozilla.org/integration/autoland/rev/9ba365837090
Make GetDeviceCollection accessible only by the enumerator. r=padenot

Clearing NI.

Flags: needinfo?(achronop)
Depends on: 1538544
Regressions: 1734748
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: