1534313 - Make the CubebDeviceEnumerator the only path to enumerate audio devices

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P2)

Description

[Alex Chronopoulos [:achronop]]

We want that because the CubebDeviceEnumerator contains logic to touch the devices as less as possible on repeating enumerations.

Also, one more patch has been added to move the default output device on the top of the list of output devices, similar to input devices.

Comment 1

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1534313 - Put the default audio output first in the list of devices. r=padenot

Comment 2

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1534313 - Add new method in enumerator to get the device info from device name. r=padenot

Comment 3

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1534313 - Remove direct calls to GetDeviceCollection method. r?padenot

Comment 4

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1534313 - Make GetDeviceCollection accessible only by the enumerator. r?padenot

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4252f238b68
Put the default audio output first in the list of devices. r=padenot
https://hg.mozilla.org/integration/autoland/rev/eae4a9ff0b9b
Add new method in enumerator to get the device info from device name. r=padenot
https://hg.mozilla.org/integration/autoland/rev/fc232edfe6e8
Remove direct calls to GetDeviceCollection method. r=padenot
https://hg.mozilla.org/integration/autoland/rev/fe17244230e8
Make GetDeviceCollection accessible only by the enumerator. r=padenot

Comment 6

[Stefan Hindli [:stefan_hindli]]

Backed out 4 changesets (Bug 1534313) for causing a perfmafailing Gtest in /builds/worker/workspace/build/application/firefox/gmp-clearkey CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=516e8d10ccedbe78cbba99fbfa940f461faa4b4a&searchStr=linux%2Cx64%2Casan%2Ctest-linux64-asan%2Fopt-gtest%2C%28gtest%29&selectedJob=234575512

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=234575512&repo=autoland&lineNumber=1217

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f9968338e4e
Backed out 4 changesets for causing a perfmafailing Gtest in /builds/worker/workspace/build/application/firefox/gmp-clearkey CLOSED TREE

Comment 8

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a98b32ebd27718b763e639a9e5a737caec4c606a

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/383d67dc9870
Put the default audio output first in the list of devices. r=padenot
https://hg.mozilla.org/integration/autoland/rev/a7fb15aa8492
Add new method in enumerator to get the device info from device name. r=padenot
https://hg.mozilla.org/integration/autoland/rev/f6916040dea3
Remove direct calls to GetDeviceCollection method. r=padenot
https://hg.mozilla.org/integration/autoland/rev/9ba365837090
Make GetDeviceCollection accessible only by the enumerator. r=padenot

Comment 10

[Alex Chronopoulos [:achronop]]

Clearing NI.

Comment 11

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/383d67dc9870
https://hg.mozilla.org/mozilla-central/rev/a7fb15aa8492
https://hg.mozilla.org/mozilla-central/rev/f6916040dea3
https://hg.mozilla.org/mozilla-central/rev/9ba365837090