1534351 - Not able to change desktop background colour more than once in set desktop background dialog

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect, P2)

Description

[Ian Moody [:Kwan] (UTC+0)]

20:32.32 INFO: Last good revision: 2ee2f297c4106e017231ed67fba4034d766c942b
20:32.32 INFO: First bad revision: c4bf214bd2e65e460fcd24a6483635c1d5cb4771
20:32.32 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2ee2f297c4106e017231ed67fba4034d766c942b&tochange=c4bf214bd2e65e460fcd24a6483635c1d5cb4771

c4bf214bd2e6 Andrea Marchesini — Bug 1459264 - Allow just 1 FilePicker per event - tests, r=smaug
3c2dc7c0e8c9 Andrea Marchesini — Bug 1459264 - Allow just 1 FilePicker per event, r=smaug
a5ad58077bd8 Andrea Marchesini — Bug 167475 - iframes should load just URLs able to return data, r=smaug

STR:

1. Right click on an image
2. Chose "Set As Desktop Background..."
3. Click the colour picker
4. Hit select (or platform equiv.) in the colour selection dialog that opens
5. Click the colour picker again

AR:
Nothing

ER:
Colour selection dialog opens again

[Tracking Requested - why for this release]:
UI regression

Comment 1

[Andrea Marchesini [:baku]]

Gijs, can you help me with this? On linux it seems we don't expose this feature.

Comment 2

[:Gijs (he/him)]

(In reply to Andrea Marchesini [:baku] from comment #1)

Gijs, can you help me with this? On linux it seems we don't expose this feature.

I'm not sure I follow. The stretch/tile/colour stuff is hidden only on mac, per this ifdef:

https://searchfox.org/mozilla-central/source/browser/components/shell/content/setDesktopBackground.xul#43-63

I don't know what you mean by "we don't expose this feature". I just checked on my ubuntu VM, and I can see the same dialog I see on Windows, with a color button in the top right corner.

Comment 3

[Pascal Chevrel (relman team) -> :pascalc]

I can reproduce in Ubuntu 18.10, tracking for 67 as this is a functional regression and I would take a safe uplift.

Comment 4

[Liz Henry (:lizzard)]

I probably would not take an uplift on release 66. Seems like someone who wants to do this would have workarounds available, like downloading the image and setting their background from the OS.

Comment 5

[Ian Moody [:Kwan] (UTC+0)]

(In reply to Liz Henry (:lizzard) (use needinfo) from comment #4)

I probably would not take an uplift on release 66. Seems like someone who wants to do this would have workarounds available, like downloading the image and setting their background from the OS.

They can actually still set it since the popup works once, they just can't change this mind and pick something else (without closing and re-opening the dialog). I was mainly concerned this might indicate a more serious bug in the code for bug 1459264. However I couldn't reproduce with the <input type="color">s in about:preferences, so I'm not sure what makes the dialog special. (The obvious check, of the Principal, seems to indicate it is the expected System Principal)

Comment 6

[Andrea Marchesini [:baku]]

Attachment: Bug 1534351 - HTMLInputElement should always allow popups for system principal, r?smaug

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2647a23c02bf
HTMLInputElement should always allow popups for system principal, r=smaug

Comment 8

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 2647a23c02bf (Bug 1534351) for mochitest failures at test_multipleFilePicker.html.

Backout: https://hg.mozilla.org/integration/autoland/rev/6a948ab124ae27dc4f66bd7059505ae11b096fc4

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=2647a23c02bfbedd487e436835fca01ba06f1c7c&selectedJob=239117522

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=239117522&repo=autoland&lineNumber=4000

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13c70f92856e
HTMLInputElement should always allow popups for system principal, r=smaug

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/13c70f92856e

Comment 11

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 68.0a1 (2019-05-03) on Windows 10 x 64, Windows 7 x32 and on Ubuntu 18.04 x64.