1534395 - Rename TabParent/TabChild to BrowserParent/BrowserChild

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Ryan Hunt [:rhunt]]

TabParent and TabChild implement the PBrowser protocol. In bug 1523072 comment 11, we decided to rename the implementations to match the protocol for Fission.

The 'Tab' naming goes beyond these implementations into 'TabContext', 'TabId', and 'nsITabParent'. This bug is just for the first step of the protocol implementations.

Comment 1

[Ryan Hunt [:rhunt]]

Build is green on today's mozilla-central [1]. It's not very hard to rebase, thankfully.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=27d304e833a666c58538858597aec4df62649b1e

Comment 2

[Ryan Hunt [:rhunt]]

Attachment: Bug 1534395 - Automatic rename of TabParent/TabChild to BrowserParent/BrowserChild. r?nika

Comment 3

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:rhunt, could you have a look please?

Comment 4

[Ryan Hunt [:rhunt]]

I've been on some PTO and decided there might be a better approach here, so I didn't land the patch here intentionally.

Comment 5

[Jonathan Watt [:jwatt]]

I rebased some of these patches:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8cf24f03bc2e31376dfcff002e9d5dda2ba5de7

Comment 6

[Ryan Hunt [:rhunt]]

I've rebased all of the patches. Try looks green, need to do a larger test run, but should be good enough to start review.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=92e3411917573c9be52c3872c5793850fcaa8e37

Comment 7

[Ryan Hunt [:rhunt]]

Attachment: Bug 1534395 - Unified build fixes. r?nika

File renames cause some unified build issues. This commit adds the missing headers.

Comment 8

[Ryan Hunt [:rhunt]]

Attachment: Bug 1534395 - Rename mRemoteBrowser to mBrowserParent in nsFrameLoader. r?nika

Depends on D28130

Comment 9

[Ryan Hunt [:rhunt]]

Attachment: Bug 1534395 - Rename nsITabParent to nsIRemoteTab. r?nika

nsITabParent is exposed to frontend code and is generally used as a representation of a remote tab. We could just rename the interface to nsIBrowserParent and worry about it later, but I think it's better to rename the interface to nsIRemoteTab so that we can later work on splitting the interface away from the PBrowser protocol.

Note: Some frontend code refers to a TabParentId. This commit renames this to RemoteTabId. We need to figure out the purpose of TabId with fission.

Depends on D28131

Comment 10

[Ryan Hunt [:rhunt]]

Attachment: Bug 1534395 - Rename TabParent to BrowserParent. r?nika

This commit renames TabParent to BrowserParent.

Depends on D28132

Comment 11

[Ryan Hunt [:rhunt]]

Attachment: Bug 1534395 - Rename nsITabChild to nsIBrowserChild. r?nika

Similarly to nsITabParent, TabChild is exposed to frontend code via nsITabChild. It's not clear what the future of this interface will be, but for now we can just rename it to nsIBrowserChild.

Depends on D28133

Comment 12

[Ryan Hunt [:rhunt]]

Attachment: Bug 1534395 - Rename TabChild to BrowserChild. r?nika

This commit renames TabChild to BrowserChild.

Depends on D28134

Comment 13

[Ryan Hunt [:rhunt]]

Latest try run with patches rebased.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cca37f1e5fa52b752cd7819509d4f1c1920d4789

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d7938f30e54
Unified build fixes. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/e02c6844c4c3
Rename mRemoteBrowser to mBrowserParent in nsFrameLoader. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/96a7836e16e2
Rename nsITabParent to nsIRemoteTab. r=nika,mconley
https://hg.mozilla.org/integration/mozilla-inbound/rev/47813ecb1f4e
Rename TabParent to BrowserParent. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/9998ccf0c05f
Rename nsITabChild to nsIBrowserChild. r=nika,mconley
https://hg.mozilla.org/integration/mozilla-inbound/rev/9813ce146bc7
Rename TabChild to BrowserChild. r=nika

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a2478c53c19
Fixup unified build bustage. r=me on a CLOSED TREE

Comment 16

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0d7938f30e54
https://hg.mozilla.org/mozilla-central/rev/e02c6844c4c3
https://hg.mozilla.org/mozilla-central/rev/96a7836e16e2
https://hg.mozilla.org/mozilla-central/rev/47813ecb1f4e
https://hg.mozilla.org/mozilla-central/rev/9998ccf0c05f
https://hg.mozilla.org/mozilla-central/rev/9813ce146bc7
https://hg.mozilla.org/mozilla-central/rev/5a2478c53c19