implement getSynchronizationSources for Video
Categories
(Core :: WebRTC, enhancement, P4)
Tracking
()
People
(Reporter: ng, Assigned: ng, NeedInfo)
References
(Depends on 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(2 files)
getSynchronizationSources is not implemented for video, only audio where it's primary purpose is to get the audio levels of packets. This probably isn't too hard, however there hasn't been anyone asking for it yet either.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
I also filed: https://github.com/web-platform-tests/wpt/issues/15828, which is a bug against the test suite requiring the optional field 'voiceActivityFlag'.
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
Bug 1534466 - P1 refactor RtpSourceObserver to accept RTPHeader
Bug 1534466 - P2 Add RtpSourceObserver to VideoConduit
Bug 1534466 - P3 Update WPT ini to reflect newly passing tests
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
||
Comment 8•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ng, could you have a look please?
Pushed by na-g@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/4f641f92edb2 implement getContributingSources and getSynchronizationSources for video r=jib
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
|
||
Comment 11•5 years ago
|
||
We've got these documented, but we should probably update the compat data.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 12•5 years ago
•
|
||
Did we previously have these in IDL and implemented to do nothing? I see no WebIDL changes here, which you normally do when API support is added for methods... according to the docs we already have in place, we have had these since Firefox 59. Was that audio only?
|
|
||
Updated•5 years ago
|
|
|
||
Comment 13•5 years ago
|
||
I've performed the following updates:
- Submitted BCD PR 4340 to add data about audio and video track support to
getContributingSources()andgetSynchronizationSources() - Added a bullet point to the WebRTC section on Firefox 68 for developers, under APIs
|
||
Comment 14•4 years ago
|
||
I'm not seeing any modifications to VideoConduit in this landing, and the wpt for video is still timing out. Did some part of this patchset get lost somehow?
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 16•4 years ago
|
||
Yes, looking at the patch is history in fabricator the changes to VideoConduit were dropped. I will see about this today.
|
|
Assignee | |
Comment 17•4 years ago
|
||
|
|
Assignee | |
Comment 18•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=283a2a6032e02e63018f39d0716efea33a9daf7e
|
|
Assignee | |
Comment 19•4 years ago
|
||
Some of the changes were lost during a rebase before landing it. I have restored those changes, which had been reviewed previously, but a refactoring of the timestamp code means that some new changes needed to be made. This patch includes turning on the relavent WPTs which provide coverage.
|
|
Assignee | |
Comment 20•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6580e35975d5341adf769f50ca1b7dc247b38494
|
||
Comment 21•4 years ago
|
||
Pushed by na-g@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/e102ee3e495a P2 - add missing video impl for GetRtpSources;r=jib
|
||
Comment 22•4 years ago
|
||
| bugherder | ||
Description
•