1534480 - Do not update Fluent DOM attributes if they match current ones

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P3)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

DOMLocalization.setAttributes can detect when the old and new id/args are the same and avoid setting them, which in turn avoids Mutations and inheritance in XBL.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1534480 - Do not update Fluent DOM attributes if they match current ones. r?bgrins,smaug,stas

Comment 2

[Brian Grinstead [:bgrins]]

This appears to fix the churn issue I mention in https://github.com/projectfluent/fluent.js/issues/300, meaning there will be much less back-and-forth on accesskey formatting with the label Custom Element (Bug 1448213).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8acb6aa4a52
Do not update Fluent DOM attributes if they match current ones. r=smaug

Comment 4

[Arthur Iakab [arthur_iakab]]

Backed out changeset a8acb6aa4a52 (bug 1534480)for chrome mochitest failures on dom_overlays/test_same_attribute.html CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/140dfb5fd701bdf3d0feb04363bd32d485552421

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=a8acb6aa4a5217a4a53dbf901ef61faecc07daf6&selectedJob=240726007&searchStr=android%2C4.3%2Capi16%2B%2Cdebug%2Cmochitests%2Cwithout%2Ce10s%2Ctest-android-em-4.3-arm7-api-16%2Fdebug-mochitest-chrome-1proc-6%2Cm-1proc%28c6%29

First it started to fail on Tier 2 TestVerify and then on Tier 1 Mochitest Chrome

Failure logs https://treeherder.mozilla.org/logviewer.html#?job_id=240725969&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=240726007&repo=autoland

:gandalf can you please take a look?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7f4cfa92ebf
Do not update Fluent DOM attributes if they match current ones. r=smaug

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f7f4cfa92ebf