Do not update Fluent DOM attributes if they match current ones

RESOLVED FIXED in Firefox 68

Status

()

defect
P3
normal
RESOLVED FIXED
3 months ago
27 days ago

People

(Reporter: zbraniecki, Assigned: zbraniecki)

Tracking

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

DOMLocalization.setAttributes can detect when the old and new id/args are the same and avoid setting them, which in turn avoids Mutations and inheritance in XBL.

Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Priority: -- → P3

This appears to fix the churn issue I mention in https://github.com/projectfluent/fluent.js/issues/300, meaning there will be much less back-and-forth on accesskey formatting with the label Custom Element (Bug 1448213).

Blocks: 1448213
Attachment #9050164 - Attachment description: Bug 1534480 - Do not update Fluent DOM attributes if they match current ones. r?bgrins → Bug 1534480 - Do not update Fluent DOM attributes if they match current ones. r?bgrins,smaug,stas

Comment 3

2 months ago
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8acb6aa4a52
Do not update Fluent DOM attributes if they match current ones. r=smaug

Comment 5

2 months ago
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f7f4cfa92ebf
Do not update Fluent DOM attributes if they match current ones. r=smaug

Comment 6

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Flags: needinfo?(gandalf)
You need to log in before you can comment on or make changes to this bug.