1534667 - Remove statsum, sentry support from aws-provisioner, ec2-manager

Status: RESOLVED FIXED

(Taskcluster :: General, enhancement)

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

aws-provisioner uses tc-lib-monitor@5.4.0, the code for which is here
https://github.com/taskcluster/taskcluster-lib-monitor/tree/ed33b91b154da51212f5bf1f992c6215408c1bad/src

We want to not pass taskcluster credentials to the constructor (since it will just use them to try to call the auth service). To allow that, we also need to pass enable:false. aws-provisioner doesn't use any logging support in tc-lib-monitor, so that's only going to disable error reporting and metrics. Metrics looks like it will work fine. And if disabled, error reporting logs to console. So I think we're in good shape.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/aws-provisioner/pull/198

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Ec2-manager seems to have a mishmash of tc-lib-* versions that results in its tests trying to access api/ec2-manager/v1/ping, but the service not serving on that path. I'm not sure how that happened (I thought its tests were in better shape).

https://github.com/taskcluster/ec2-manager/pull/78

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

provisioner-staging works fine

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

& production

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

ec2-manager-staging says

2019-03-12T22:47:35.293815+00:00 app[web.1]: { AssertionError [ERR_ASSERTION]: Must provide a rootUrl to taskcluster-lib-monitor

so I pushed a fix to add that back and landed it. All set!