1534673 - Stop paying attention to msid-semantic when parsing a=msid

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P2)

Description

[Byron Campen [:bwc]]

msid-semantic is no longer in the jsep spec, because we aren't using the appdata portion anymore. We should just accept all a=msid.

Comment 1

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3fcbe5f7c175fff101d0d1a3ccbd8f911096f7e

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1534673 - Part 0: Add some test-cases for sdp without msid-semantics. r?jib

Depends on D23202

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1534673 - Part 1: Stop paying attention to a=msid-semantic. Simplify some code that was still paying attention to the appdata part of msid. r?mjf

Depends on D23203

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 1534673 - Part 2: Update a couple of mochitests to stop checking track ids. r?jib

Depends on D23205

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 1534673 - Part 3: Some updates to jsep_session_unittest to avoid comparing track-ids, and stop using msid-semantic. r?mjf

Depends on D23207

Comment 7

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=12552f4fce50a0741ed3b75db01968054162c69d

Comment 8

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=25e041d722847dcae5006481ca0c3e644fc0e5dc

Comment 9

[Byron Campen [:bwc]]

Attachment: Bug 1534673 - Part 4: Stop comparing track ids in jsep_track_unittest. r?mjf

Depends on D23208

Comment 10

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ccb501d18f7ce1d1ce012f99f5a507e411bc69f5

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05f0176414e7
Part 0: Add some test-cases for sdp without msid-semantics. r=jib
https://hg.mozilla.org/integration/autoland/rev/99269d93d2bf
Part 1: Stop paying attention to a=msid-semantic. Simplify some code that was still paying attention to the appdata part of msid. r=mjf
https://hg.mozilla.org/integration/autoland/rev/d31734f78683
Part 2: Update a couple of mochitests to stop checking track ids. r=jib
https://hg.mozilla.org/integration/autoland/rev/5701b7be457c
Part 3: Some updates to jsep_session_unittest to avoid comparing track-ids, and stop using msid-semantic. r=mjf
https://hg.mozilla.org/integration/autoland/rev/a490015d86a6
Part 4: Stop comparing track ids in jsep_track_unittest. r=mjf

Comment 12

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/05f0176414e7
https://hg.mozilla.org/mozilla-central/rev/99269d93d2bf
https://hg.mozilla.org/mozilla-central/rev/d31734f78683
https://hg.mozilla.org/mozilla-central/rev/5701b7be457c
https://hg.mozilla.org/mozilla-central/rev/a490015d86a6

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16712 for changes under testing/web-platform/tests