1534677 - Verify "lang" values in ManifestProcessor.jsm

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

The following comment appears:

  // TODO: Check if tag is structurally valid.
  //       Cannot do this because we don't support Intl API on Android.
  //       https://bugzilla.mozilla.org/show_bug.cgi?id=864843
  //       https://github.com/tc39/ecma402/issues/5

We have the Intl API available now, so we should be able to do something here.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Marcos, feel free to let me know if we should have higher priority. Thanks!

Comment 2

[Marcos Caceres [:marcosc]]

p3 is fine. Will try to start on this soon.

Comment 3

[Marcos Caceres [:marcosc]]

Attachment: Bug 1534677 - Verify lang member in ManifestProcessor.jsm

Implement language tag validation and canonicalization for lang member

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0394b2d9173
Verify lang member in ManifestProcessor.jsm r=snorp

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for m-e10s failures on test_ManifestProcessor_lang.html

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=c0394b2d91732e702df13ac4c9f4180a8e06e80e&searchStr=m-e10s&selectedJob=238988632

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238988632&repo=autoland&lineNumber=8072

Backout link: https://hg.mozilla.org/integration/autoland/rev/0523ad54267a92d45bcee3986d09b3cdb5954504

[task 2019-04-09T05:48:26.328Z] 05:48:26 INFO - TEST-PASS | dom/manifest/test/test_ManifestProcessor_lang.html | Expect non-string to be undefined.
[task 2019-04-09T05:48:26.329Z] 05:48:26 INFO - TEST-PASS | dom/manifest/test/test_ManifestProcessor_lang.html | Expect non-string to be undefined.
[task 2019-04-09T05:48:26.331Z] 05:48:26 INFO - Buffered messages finished
[task 2019-04-09T05:48:26.332Z] 05:48:26 INFO - TEST-UNEXPECTED-FAIL | dom/manifest/test/test_ManifestProcessor_lang.html | Expect lang to be "aa" - got undefined, expected "aa"
[task 2019-04-09T05:48:26.332Z] 05:48:26 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:320:16
[task 2019-04-09T05:48:26.334Z] 05:48:26 INFO - @dom/manifest/test/test_ManifestProcessor_lang.html:64:3
[task 2019-04-09T05:48:26.335Z] 05:48:26 INFO - Not taking screenshot here: see the one that was previously logged

Comment 6

[Marcos Caceres [:marcosc]]

Thanks, :CosminS. Will investigate.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b937a1bec90
Verify lang member in ManifestProcessor.jsm r=snorp

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/9b937a1bec90