1534687 - RTCRtpParameters.codecs aren't populated

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P3)

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1534687: Test cases for RTCRtpParameters.codecs. r?jib

Includes some tests that compat mode ignores any attempt to set .codecs.

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1534687: Implement RTCRtpParameters.codecs and RTCRtpReceiver.getParameters r?jib

We do not mark this field as required right now, because we still have users
that synthesize RTCRtpParameters instead of tweaking the return of
getParameters. The compat mode will ignore any attempt to modify .codecs,
otherwise this will result in the error specified in webrtc-pc.

Depends on D209304

Comment 3

[Byron Campen [:bwc]]

Try looks good:

https://treeherder.mozilla.org/jobs?repo=try&revision=bae01e2e4ade1609c19e6e7127bbbfc7b94fa197
https://treeherder.mozilla.org/jobs?repo=try&revision=d032631da362b13ee6933fde528c6a6ffa071534
https://treeherder.mozilla.org/jobs?repo=try&revision=45f2ff1cd6ef96c7c53a0785f16687da2444c754

IIRC there are some other places in the wpt tree that might touch this API, will check up on those next.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42c06449d631
Test cases for RTCRtpParameters.codecs. r=jib
https://hg.mozilla.org/integration/autoland/rev/1edceea62ecd
Implement RTCRtpParameters.codecs and RTCRtpReceiver.getParameters r=jib,webidl,smaug

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46610 for changes under testing/web-platform/tests

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/42c06449d631
https://hg.mozilla.org/mozilla-central/rev/1edceea62ecd

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Hamish Willee]

FYI MDN FF128 docs work for this tracked in https://github.com/mdn/content/issues/33988 (in review)