1534721 - Handle fields in derived classes

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Ashley Hauck [:khyperia]]

Currently, fields in derived classes are just entirely broken. Let's fix that.

Comment 1

[Ashley Hauck [:khyperia]]

Attachment: Bug 1534721 - Handle fields in derived classes.

Comment 2

[Jason Orendorff [:jorendorff]]

Leaving a note, because I'm not quite ready to review this patch yet.

Three sanity tests to put in the test suite:

class Base {
}
class C extends Base {
  field;
}
new C();

$ $DJS --enable-experimental-fields ../../../../crasher.js
Assertion failure: (activation.regs()).stackDepth() == 0 || (*(activation.regs()).pc == JSOP_AWAIT && !(activation.regs()).fp()->isResumedGenerator()), at /Users/jorendorff/work/gecko/js/src/vm/Interpreter.cpp:2127

class Base {
}
var C = class extends Base {
  field;
};
new C();

$ $DJS --enable-experimental-fields ../../../../crasher.js
Assertion failure: env == cx->global() || env == &cx->global()->lexicalEnvironment() || env->is<RuntimeLexicalErrorObject>(), at /Users/jorendorff/work/gecko/js/src/vm/Interpreter-inl.h:315

class Base {
}
class C extends Base {
  field;
  constructor() {
    super();
  }
};
new C();

$ $DJS --enable-experimental-fields ../../../../crasher.js
Assertion failure: next == JSOP_CHECKTHIS || next == JSOP_CHECKRETURN || next == JSOP_CHECKTHISREINIT, at /Users/jorendorff/work/gecko/js/src/vm/Interpreter.cpp:3520

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/048424eb3075
Handle fields in derived classes. r=jorendorff

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 048424eb3075 (bug 1534721) for SpiderMonkey failures in builds/worker/workspace/build/src/js/src/frontend/BytecodeEmitter.cpp:8057. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238831500&repo=autoland&lineNumber=592

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=048424eb3075256daa7ee76cd536d24d75505cee

Backout:
https://hg.mozilla.org/integration/autoland/rev/9625a25b6e3839b776612dc637abac320de7d625

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed722cf1b2d9
Handle fields in derived classes. r=jorendorff

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/ed722cf1b2d9