1534756 - Don't throw exception in ManifestObtainer if a document has no manifest

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

It should just return null or a default manifest.

Comment 1

[Marcos Caceres [:marcosc]]

Started working on this.

Comment 2

[Marcos Caceres [:marcosc]]

Attachment: Bug 1534756 - Don't throw exception in ManifestObtainer if a document has no manifest

We now return null when the manifest lacks a href or is missing.

Comment 3

[Marcos Caceres [:marcosc]]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f52927edcad21af04dd79e32aaa07fa478f4c6d5

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea2baf2c9ae7
Don't throw exception in ManifestObtainer if a document has no manifest r=snorp

Comment 5

[Cristian Brindusan [:cbrindusan]]

Backed out changeset ea2baf2c9ae7 (Bug 1534756) for mochitest failures at test_ManifestProcessor_JSON.html.

Backout: https://hg.mozilla.org/integration/autoland/rev/6f7ba873b5b04b9b23313cb191e011377b0128d3

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=ea2baf2c9ae7cc2a1a9fc9e410efb7e986bf5d9b&selectedJob=239257960

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=ea2baf2c9ae7cc2a1a9fc9e410efb7e986bf5d9b&selectedJob=239248209

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=239248209&repo=autoland&lineNumber=2680

Comment 6

[Marcos Caceres [:marcosc]]

Thanks! Investigating....

Comment 7

[Marcos Caceres [:marcosc]]

Attachment: Bug 1534756 - Don't throw exception in ManifestObtainer if a document has no manifest

We now return null when the manifest lacks a href or is missing.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d73ccfdab07c
Don't throw exception in ManifestObtainer if a document has no manifest r=snorp

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/d73ccfdab07c