Improve blocked cursor behavior to fall back to next image.

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

I think it's better to fall back to the next cursor image rather than blocking all cursor images altogether. This also cleans up a bit.

Assignee

Comment 1

2 months ago

Right now we just block the image returned from nsIFrame::GetCursor, which is
the first loading cursor image.

I think we should do the same we do when the image fails to load, which is to
fall back to the next image instead.

This patch moves all the custom cursor code selection logic to
EventStateManager, and lets the frame return a CursorKind and whether custom
images are allowed.

Comment 2

2 months ago
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a4d1dd58552d
Improve blocked cursor behavior to fall back to next image. r=smaug

Comment 3

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.