1535026 - Android 'mach marionette-test' should not require explicit --disable-e10s for Fennec

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P1)

Description

[Geoff Brown [:gbrown]]

Currently this command runs tests correctly

mach marionette-test --app=fennec --emulator --address=127.0.0.1:2828 --disable-e10s

but this one launches fennec and then stalls, not running any tests:

mach marionette-test --app=fennec --emulator --address=127.0.0.1:2828

When app=fennec, mach should assume --disable-e10s.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Just to make sure through the summary this is for Fennec only.

The code to be updated should be here:
https://searchfox.org/mozilla-central/rev/89414a1df52d06cfc35529afb9a5a8542a6e4270/testing/marionette/mach_commands.py#77-86

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It looks like that with mozbuild I can only check for is_android but that most likely would include Fennec and GeckoView. GeckoView should be fine with e10s, so it won't need to be forced to disable e10s.

Mike, is there an environment variable which allows us to differentiate between Fennec and GeckoView?

https://searchfox.org/mozilla-central/rev/aae527894a97ee3bbe0c2cfce9c67c59e8b8fcb9/python/mozbuild/mozbuild/base.py#923-927

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I think I will actually implement what mochitest does:
https://searchfox.org/mozilla-central/rev/aae527894a97ee3bbe0c2cfce9c67c59e8b8fcb9/testing/mochitest/mach_commands.py#181

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1535026 - [marionette] 'mach marionette-test' should force e10s disabled for Fennec. r=ato

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please note that I put the patch into mach and not the harness itself. Reason is that I still want to leave up the option to try running with e10s, and not having to release a new version to PyPI in case something changes in the future.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0607c72b4d88
[marionette] 'mach marionette-test' should force e10s disabled for Fennec. r=ato

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0607c72b4d88