Closed Bug 1535026 Opened 1 year ago Closed 1 year ago

Android 'mach marionette-test' should not require explicit --disable-e10s for Fennec

Categories

(Testing :: Marionette, enhancement, P1)

Version 3
enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: gbrown, Assigned: whimboo)

References

Details

Attachments

(1 file)

Currently this command runs tests correctly

mach marionette-test --app=fennec --emulator --address=127.0.0.1:2828 --disable-e10s

but this one launches fennec and then stalls, not running any tests:

mach marionette-test --app=fennec --emulator --address=127.0.0.1:2828

When app=fennec, mach should assume --disable-e10s.

Just to make sure through the summary this is for Fennec only.

The code to be updated should be here:
https://searchfox.org/mozilla-central/rev/89414a1df52d06cfc35529afb9a5a8542a6e4270/testing/marionette/mach_commands.py#77-86

Priority: -- → P3
Summary: Android 'mach marionette-test' should not require explicit --disable-e10s → Android 'mach marionette-test' should not require explicit --disable-e10s for Fennec

It looks like that with mozbuild I can only check for is_android but that most likely would include Fennec and GeckoView. GeckoView should be fine with e10s, so it won't need to be forced to disable e10s.

Mike, is there an environment variable which allows us to differentiate between Fennec and GeckoView?

https://searchfox.org/mozilla-central/rev/aae527894a97ee3bbe0c2cfce9c67c59e8b8fcb9/python/mozbuild/mozbuild/base.py#923-927

Flags: needinfo?(mh+mozilla)
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P3 → P1

Please note that I put the patch into mach and not the harness itself. Reason is that I still want to leave up the option to try running with e10s, and not having to release a new version to PyPI in case something changes in the future.

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0607c72b4d88
[marionette] 'mach marionette-test' should force e10s disabled for Fennec. r=ato
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.