1535155 - Add `#Check-in Needed` "tag" type project to Phabricator

Status: RESOLVED FIXED

(Conduit :: Phabricator, enhancement)

Description

[Kim Moir [:kmoir] ET]

from bug 1514807

Going to brain dump a little on how this should work and what questions we need to answer:

• A #Check-in Needed "tag" type project[1] should be added to Phabricator.
  • Name: Check-in Needed
  • Description: <description explaining purpose and use (possibly linking to docs)>
  • Icon: Tag
  • Color: Not red[2]. Maybe start a new convention for tags?
  • Additional Hashtags: checkin-needed [3]
  • Visible To: "Public (No Login Required)", so that anyone can see it tagged on things, and query with it.
    • Note that this will not expose confidential revision's marked with checkin-needed, the Phabricator docs on projects[1] have more details on the security model.
  • Editable By: Administrators
  • Joinable By: No One
• The new tag can be added to revisions by any user with edit-bugs.
• Sheriffs may query for revisions with the tag, and trigger landings using Lando.
• Some process or automation must remove the tag either at landing time, or backout time.

Comment 1

[David Lawrence [:dkl]]

checkin-needed project tag added to phab-prod, phab-stage, and phab-dev.

https://phabricator.services.mozilla.com/project/view/99/

I will need to add a description at some point even though it will work without one. Could someone give me a brief description or point me to some docs describing it's purpose.

Also update the mana doc about creating projects to try and standardize on the colors and icons for different project types.

Icons:

• Group: For projects intended to act as groups of users, such as a set of reviewers for a specific topic.
• Tag: For projects that are just for logical tagging of revisions and other objects to aid in searching.
• Lock: For security related projects used for policies, etc.

Colors:

• Green: Used for all projects created to act as a group of users, such as a set of reviewers for a specific topic.
• Red: Used for automatically synchronized BMO groups and other security policy related projects (i.e. secure-revision).
• Blue: Should be used for all tags used for logical grouping of revision and other objects making it easy to search.

feedback?

Comment 2

[Kim Moir [:kmoir] ET]

Here are docs on the uplift process to help craft a description

https://wiki.mozilla.org/Release_Management/Uplift_rules

I think the standard icons and colours sound fine.

Comment 3

[David Lawrence [:dkl]]

Description updated. Closing.