Cleanup a few other bitfield-valued CSS properties.

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P3
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

unspecified
mozilla68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(3 attachments)

No description provided.
Assignee

Comment 2

3 months ago

And rename the constants to not be prefixed by TOUCH_ACTION_, since that's part
of the type name anyway.

Depends on D23412

My r+ on the first patch is only for the first ~90% of that patch -- please get an additional reviewer (someone more rust/stylo-comfortable than I am) to take a look at the parsing chunk there.

[also mentioned in phabricator -- just posting as "needinfo" to be more sure you see this before triggering autoland when seeing r+ all around]

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Status: NEW → ASSIGNED
Priority: -- → P3

Comment 5

3 months ago
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5797a6719d5b
Use cbindgen for text-decoration-line. r=dholbert,boris
https://hg.mozilla.org/integration/autoland/rev/8a5a706e25c8
Use cbindgen for touch-action. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/590e76eeb3e8
Make the will-change bitfield use cbindgen. r=dholbert

Comment 6

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.