1535166 - Implement computed field names

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Ashley Hauck [:khyperia]]

Currently, computed field names are not supported. Let's fix that.

class C {
    ["x"] = 2;
}

Also, implement some easier, half-related other cases, like:

class C {
    2 = 2;
    0b01 = 2;
    "hello" = 2;
}

Also, fix a related bug: we currently don't emit an initializer for this

class C {
    x;
}

which is incorrect, and especially apparent when there's a computed field with side effect as the field-without-an-initializer.

Comment 1

[Ashley Hauck [:khyperia]]

Attachment: Bug 1535166 - Implement computed field names.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b8c42577e24
Implement computed field names. r=jorendorff

Comment 3

[Andreea Pavel [:apavel]]

Backed out for build bustages at Parser.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=339f5b718539f0226cb1c9ac638b358d4fe8113a&selectedJob=234875524

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=234875524&repo=autoland&lineNumber=5647

Backout: https://hg.mozilla.org/integration/autoland/rev/1017d1e09b8864cc8ea41f5f29714b5a54d77f77

Comment 4

[Andreea Pavel [:apavel]]

There is also this assertion failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=234892102&repo=autoland&lineNumber=7518

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d96f98f974e0
Implement computed field names. r=jorendorff

Comment 6

[Ashley Hauck [:khyperia]]

Clearing NI - the build issue was super easy, the assertion failure less so. Pushed updated version with both fixed.

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d96f98f974e0