Closed Bug 1535448 Opened 2 years ago Closed 2 years ago

[Accessibility] In Pocket New Tab handle focus state while navigating with keyboard

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 68
Iteration:
68.4 - Apr 29 - May 12
Tracking Status
firefox68 --- verified

People

(Reporter: pdahiya, Assigned: gsuntop)

References

Details

(Keywords: github-merged)

Attachments

(2 files)

Scope of this bug is to handle focus state while tabbing through discovery stream layouts using keyboard.

See https://github.com/mozilla/activity-stream/pull/4851#pullrequestreview-214736491

Including Wolasi for design inputs on this issue. Thanks!

Flags: needinfo?(wkonu)
Blocks: 1536131
Priority: -- → P1
Iteration: --- → 68.1 - Mar 18 - 31
Assignee: nobody → gsuntop
Severity: normal → enhancement
No longer blocks: 1512725
Iteration: 68.1 - Mar 18 - 31 → 68.2 - Apr 1 - 14
Iteration: 68.2 - Apr 1 - 14 → ---
Priority: P1 → P3
Flags: needinfo?(wkonu)
Summary: In Pocket New Tab handle focus state while navigating with keyboard → [Accessibility] In Pocket New Tab handle focus state while navigating with keyboard
Iteration: --- → 68.3 - Apr 15 - 28
Priority: P3 → P1
Blocks: 1544599
Iteration: 68.3 - Apr 15 - 28 → 68.4 - Apr 29 - May 12
Blocks: 1548388
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190503041749) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now, the New Tab elements are focused when tabbing through the "Discovery Stream" layouts.

Status: RESOLVED → VERIFIED

Noticed a couple of non-blocking issues with the implementation

  • Clipping of the focus state blue outline around images, see cards and Top Sites tiles
  • Focus state should be applied to the same element as the hover state, not this isn't always the <a> tag
Flags: needinfo?(gsuntop)

Created a new bug for the issues mentioned above https://bugzilla.mozilla.org/show_bug.cgi?id=1548917

Flags: needinfo?(gsuntop)
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.