1535448 - [Accessibility] In Pocket New Tab handle focus state while navigating with keyboard

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to handle focus state while tabbing through discovery stream layouts using keyboard.

See https://github.com/mozilla/activity-stream/pull/4851#pullrequestreview-214736491

Comment 1

[Punam Dahiya [:pdahiya]]

Including Wolasi for design inputs on this issue. Thanks!

Comment 2

[Wolasi :wolasi]

Here's the Focus State spec for card and list items
https://www.figma.com/file/0xZkmT86rSXbGRB4eIvrn0ts/New-Tab-Spec-for-Fx-v68?node-id=383%3A1

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4934

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/34dd0113415f

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190503041749) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now, the New Tab elements are focused when tabbing through the "Discovery Stream" layouts.

Comment 6

[Wolasi :wolasi]

Noticed a couple of non-blocking issues with the implementation

• Clipping of the focus state blue outline around images, see cards and Top Sites tiles
• Focus state should be applied to the same element as the hover state, not this isn't always the <a> tag

Comment 7

[Wolasi :wolasi]

Attachment: Clipped focus state outline around image

Comment 8

[Wolasi :wolasi]

Created a new bug for the issues mentioned above https://bugzilla.mozilla.org/show_bug.cgi?id=1548917