Closed Bug 153545 Opened 23 years ago Closed 23 years ago

relative URLs in page info (media and other tabs)

Categories

(SeaMonkey :: Page Info, defect)

Product:
SeaMonkey
Component:
Page Info
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: u32858, Assigned: db48x)

References

(
URL
)

Details

Attachments

(1 file, 4 obsolete files)

add a catch so we at least so something on certain kinds of pages
1.08 KB, patch
jag+mozilla
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review
From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020605 BuildID: 2002060511 This page references the links locally to that site, but the full url is not given Reproducible: Always Steps to Reproduce: 1.go to http://spinner.com/prplayer/prplayer.jhtml?partner_id=1&_requestid=3760931 2. click page info, go to media and you will see /gateway/rpm.jhtml?u......etc 3. Actual Results: /gateway/rpm.jhtml?u...... Expected Results: should give the full URL etc http://spinner.com/gateway/rpm.jhtml?u......etc
Whiteboard: DUPEME
Summary: non-full URLs in media and other tabs → relative URLs in page info (media and other tabs)
OS: Linux → All
Hardware: PC → All
Attached patch make all urls absolute (obsolete) — — Splinter Review
This is all nice... except that getAbsoluteURI is broken by design. Assigning to .spec is just wrong.... You should be using newURI on the IOservice and passing it the base...
I didn't write it, I just get to use it.
Is there a bug on fixing getAbsoluteURI?
Attached patch fix getAbsoluteURL() (obsolete) — — Splinter Review
this is just the change to getAbsoluteURL(), since the other changes have been included in my patch to bug 177047, because they conflict badly. there's a testcase at http://db48x.dyndns.org/pageInfo/tests/relative.xml
Attachment #104565 - Attachment is obsolete: true
Attached patch duh. I can't read or something. (obsolete) — — Splinter Review
Attachment #104678 - Attachment is obsolete: true
Attachment #104727 - Attachment is obsolete: true
now it's ready for review.
Comment on attachment 104823 [details] [diff] [review] add a catch so we at least so something on certain kinds of pages r/sr=bzbarsky
Attachment #104823 - Flags: superreview+
Comment on attachment 104823 [details] [diff] [review] add a catch so we at least so something on certain kinds of pages r=jag
Attachment #104823 - Flags: review+
bz just checked this in.
Status: UNCONFIRMED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Removing DUPEME since it has a patch.
Whiteboard: DUPEME
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: