153545 - relative URLs in page info (media and other tabs)

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[u32858]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020605
BuildID:    2002060511

This page references the links locally to that site, but the full url is not given



Reproducible: Always
Steps to Reproduce:
1.go to http://spinner.com/prplayer/prplayer.jhtml?partner_id=1&_requestid=3760931

2. click page info, go to media and you will see /gateway/rpm.jhtml?u......etc

3.

Actual Results:  /gateway/rpm.jhtml?u......

Expected Results:  should give the full URL etc
http://spinner.com/gateway/rpm.jhtml?u......etc

Comment 1

[Daniel Brooks [:db48x]]

Attachment: make all urls absolute

Comment 2

[Boris Zbarsky [:bzbarsky]]

This is all nice... except that getAbsoluteURI is broken by design.  Assigning
to .spec is just wrong....  You should be using newURI on the IOservice and
passing it the base...

Comment 3

[Daniel Brooks [:db48x]]

I didn't write it, I just get to use it.

Comment 4

[jag (Peter Annema)]

Is there a bug on fixing getAbsoluteURI?

Comment 5

[Daniel Brooks [:db48x]]

Attachment: fix getAbsoluteURL()

this is just the change to getAbsoluteURL(), since the other changes have been
included in my patch to bug 177047, because they conflict badly.

there's a testcase at http://db48x.dyndns.org/pageInfo/tests/relative.xml

Comment 6

[Daniel Brooks [:db48x]]

Attachment: duh. I can't read or something.

Comment 7

[Daniel Brooks [:db48x]]

Attachment: it wants a charset too, for some reason.

Comment 8

[Daniel Brooks [:db48x]]

Attachment: add a catch so we at least so something on certain kinds of pages

Comment 9

[Daniel Brooks [:db48x]]

now it's ready for review.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 104823 [details] [diff] [review]
add a catch so we at least so something on certain kinds of pages

r/sr=bzbarsky

Comment 11

[jag (Peter Annema)]

Comment on attachment 104823 [details] [diff] [review]
add a catch so we at least so something on certain kinds of pages

r=jag

Comment 12

[Daniel Brooks [:db48x]]

bz just checked this in.

Comment 13

[Greg K.]

Removing DUPEME since it has a patch.