Closed Bug 1535466 Opened 5 years ago Closed 2 years ago

Should disable buffer-full-add-after-full-event web platform tests

Categories

(Core :: DOM: Performance, enhancement, P1)

All
Unspecified
enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: whawkins, Assigned: bdekoz)

Details

Based on the comments in the test source code itself (

// Since we have no strict guarantees when an entry will be added to the
// buffer, waiting till next task to try to avoid flakiness.

) I propose that we disable the buffer-full-add-after-full-event test. Given a recent proposed implementation change (see bug 1525051), we are likely to see this test intermittently pass/fail.

Suggested that this be fixed upstream:

https://github.com/web-platform-tests/wpt/issues/15849

Assignee: nobody → whawkins
Status: NEW → ASSIGNED
Priority: -- → P1

Fix submitted via upstream. Proposed fix can be viewed at https://github.com/web-platform-tests/wpt/pull/16228

Flags: needinfo?(mstange)
Flags: needinfo?(mstange)

(In reply to Will Hawkins from comment #2)

Fix submitted via upstream. Proposed fix can be viewed at https://github.com/web-platform-tests/wpt/pull/16228

Looks like the upstream fix was merged. Should this bug be closed?

Flags: needinfo?(whawkins)
Assignee: whawkins → nobody
Status: ASSIGNED → NEW
Assignee: nobody → bdekoz
Component: Performance → DOM: Performance

Redirect a needinfo that is pending on an inactive user to the triage owner.
:fdoty, since the bug has high priority and recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(whawkins) → needinfo?(fdoty)

(In reply to Daniel Holbert [:dholbert] from comment #3)

(In reply to Will Hawkins from comment #2)

Fix submitted via upstream. Proposed fix can be viewed at https://github.com/web-platform-tests/wpt/pull/16228

Looks like the upstream fix was merged. Should this bug be closed?

Marking fixed based on this comment stating fix has been merged :
hawkinsw:whh8b_fix_15849

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(fdoty)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.