1535486 - Array<octet> doesn't come out as expected in rust xpidl bindings

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: array-of-octets.diff

If I declare something in an idl like:

void passArrayOfOctets(in Array<octet> arr);

and then I want to implement this in rust, the function I have to implement is:

unsafe fn PassArrayOfOctets(&self, arr: *const ThinVec<*mut u8>) -> nsresult {

I would expect this to be:

unsafe fn PassArrayOfOctets(&self, arr: *const ThinVec<u8>) -> nsresult {

If I actually attempt to use arr as its declared type, gecko crashes. If I cast it to essentially be the type I'm expecting, it seems to work. I've attached a gtest I mocked up that demonstrates this.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Nika, is this how this is supposed to work? Or is there an underlying issue I'm not aware of here?

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Yup, this is a bug in the codegen, my bad! The types we're generating on the Rust side are wrong. I'll put up a patch to fix this inconsistency.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1535486 - Handle the element type correctly with rust XPCOM types,

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36f24a4ffdd6
Handle the element type correctly with rust XPCOM types, r=mccr8

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/36f24a4ffdd6