1535490 - Build failure with js shells on Windows

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

This command seems to fail for me at not finding llvm-config:

LINKER=lld-link.exe 'CXX="clang-cl.exe -fallback"' 'CC="clang-cl.exe -fallback"' MAKE=mozmake 'LIBCLANG_PATH="C:/Program Files/LLVM/bin"' sh c://Users//fuzz1//trees//mozilla-central//js//src//configure --host=x86_64-pc-mingw32 --target=x86_64-pc-mingw32 --disable-jemalloc --enable-debug --enable-gczeal --enable-debug-symbols --disable-tests --disable-cranelift

See the build failure stack.

autobisectjs shows this is probably related to the following changeset:

The first bad revision is:
changeset: https://hg.mozilla.org/mozilla-central/rev/2185356fb2af
user: Mike Hommey
date: Mon Feb 11 22:04:06 2019 +0000
summary: Bug 1526497 - Always get clang information for bindgen. r=ted

:glandium, is bug 1526497 a likely regressor? I only found this out recently as I was on PTO for end-Feb/start-Mar.

Let me know if I should add something to my configuration line instead.

Comment 1

[Mike Hommey [:glandium]]

That changeset only made the lack of llvm-config more apparent on your machine, AFAICT. The build would probably have failed at another stage because llvm-config is not found, and the clang-path is None. There's clearly something wrong with the failure mode, but presumably, your setup is currently missing something.

I do intend to change things in bug 1526857, hopefully next week, so this should be addressed. In the meantime, you can try setting LLVM_CONFIG or CLANG_PATH.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Historically I have been using LLVM builds downloaded off llvm.org - which I think do not have llvm-config. This method now broke as can be seen in this bug. Is there a way I can get llvm-config release binaries on Windows somewhere? Then I'll go compile the js shell via configure, after cloning m-c.

Or am I just missing something obvious?

Comment 3

[Mike Hommey [:glandium]]

For now, I guess you should use the clang from mach bootstrap.

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Mike Hommey [:glandium] from comment #3)

For now, I guess you should use the clang from mach bootstrap.

This suggestion worked for me - I set LIBCLANG_PATH to point to ~/.mozbuild/clang/bin and the shells seemed to compile.

Resolving INVALID.