1535631 - Crash in [@ dav1d_ipred_z3_avx2.h32]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-8ab80a84-84d0-4137-b8f0-ebdcc0190314.

Seen while looking at nightly crash stats - there are a series of 10.14 crashes happening with somewhat similar signatures: https://bit.ly/2Ffsy3p. The crashes seemed to have started in 20190314094420.

Possible regression range based on build id: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=aecc707103590186a2a7fa5d002849f443417e59&tochange=49d94c83bb220524a370fc7f7734de7e7307016b

Top 10 frames of crashing thread:

0 XUL dav1d_ipred_z3_avx2.h32 
1 XUL decode_b third_party/dav1d/src/decode.c:711
2 XUL decode_sb third_party/dav1d/src/decode.c
3 XUL decode_sb third_party/dav1d/src/decode.c:2054
4 XUL dav1d_decode_tile_sbrow third_party/dav1d/src/decode.c:2430
5 XUL dav1d_decode_frame third_party/dav1d/src/decode.c:2894
6 XUL dav1d_frame_task third_party/dav1d/src/thread_task.c:44
7 libsystem_pthread.dylib libsystem_pthread.dylib@0x3338 
8 libsystem_pthread.dylib libsystem_pthread.dylib@0x62a6 
9 libsystem_pthread.dylib libsystem_pthread.dylib@0x2444 

Comment 1

[Alex Chronopoulos [:achronop]]

This must be a regression of Bug 1535038.

Comment 2

[Alex Chronopoulos [:achronop]]

The crash has been reported upstream in [1]. Nevertheless, the first step is to get dav1d updated from upstream in case this is something already solved. The update is happening in Bug 1533559.

[1] https://code.videolan.org/videolan/dav1d/issues/265

Comment 3

[Neha Kochar [:neha]]

Alex, are you the correct assignee for this crash?

Comment 4

[Alex Chronopoulos [:achronop]]

Yeah, I am taking it on my name. Thanks!

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Do we have RDD on mac?

Comment 6

[Alex Chronopoulos [:achronop]]

Yes, RDD is a hard requirement for av1 and dav1d.

Comment 7

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1535631 - Use 16 byte stack alignment on dav1d in OSX. r?TD-Linux

Comment 8

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=05230b20d959dcbb642601ecf0d8ceb4091ca677

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b9f4f5a2786
Use 16 byte stack alignment on dav1d in OSX. r=TD-Linux

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2b9f4f5a2786

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Alex, since 67 is marked as affected, should we consider uplifting this to Beta67?

Comment 12

[Alex Chronopoulos [:achronop]]

Yes, we need to uplift this one, but we need other uplifts first. The uplift of Bug 1533559 is the first needed and the most important, then we need Bug 1536538 and 1536070.

Comment 13

[Alex Chronopoulos [:achronop]]

Comment on attachment 9052614 [details]
Bug 1535631 - Use 16 byte stack alignment on dav1d in OSX. r?TD-Linux

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1535038
• User impact if declined: Crash on dav1d decoder. Without it we cannot enable dav1d on beta.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1536538
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is low risk because the risk has been verified in Nightly for some time now.
• String changes made/needed:

Comment 14

[Pascal Chevrel:pascalc]

Comment on attachment 9052614 [details]
Bug 1535631 - Use 16 byte stack alignment on dav1d in OSX. r?TD-Linux

Crash fix, patch needed for the libdav1d update to 0.2.1 on beta. Uplift accepted for 67 beta 8, thanks.

Comment 15

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/aef15903ef09