Closed Bug 1535661 Opened 2 years ago Closed 2 years ago

Markup panel is empty apart from HTML tag

Categories

(DevTools :: Inspector, defect, P1)

Product:
DevTools
Component:
Inspector
Version:
62 Branch
Type:
defect

Tracking

(firefox68 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: miker, Assigned: miker)

Details

Attachments

(1 file)

Bug 1535661 - Fix CORS issues in Markup Panel r?pbro!
47 bytes, text/x-phabricator-request
Details | Review

STR

  1. Go to https://www.reuters.com/investigates/special-report/usa-politics-beto-orourke/
  2. Open the inspector
  3. Reload the page

The following exception is raised:

Error while calling actor 'domwalker's method 'children' Permission denied to access property "jQuery300023229982312416421" protocol.js:1042:13

We are trying to access a dead node somewhere and that is breaking the world.

In this case the page is loading a Twitter widget and we recurse into the iframe checking each node for events. The Twitter widget has a jQuery event but because of CORS we have no access to the script, a Security exception is thrown and the world is broken.

One change is in node.js::isScrollable() so I decided to assign this to you for review. Feel free to re-assign as you feel appropriate if you don't have time.

Try

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e2f20af3f902ea65436bcfd288b3e075d6508f8

Attachment #9051536 - Attachment description: Bug 1535661 - Markup panel is empty apart from HTML tag r?pbro! → Bug 1535661 - Fix CORS issues in Markup Panel r?pbro!
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4641d251c208
Fix CORS issues in Markup Panel r=pbro

https://hg.mozilla.org/mozilla-central/rev/4641d251c208

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Mike, this was filed and marked as a P1 just before merge Day so it in 68. Would that be something we should uplift to 67 beta?

Flags: needinfo?(mratcliffe)

To be honest it is an edge case so lets leave it.

If we receive any reports we can always uplift to beta later.

Flags: needinfo?(mratcliffe)

As per the discussion with Mike on Slack website has changed.
Removing QE+ since preparing a TC for it would involve to much time investment.

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.