1535661 - Markup panel is empty apart from HTML tag

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

STR

1. Go to https://www.reuters.com/investigates/special-report/usa-politics-beto-orourke/
2. Open the inspector
3. Reload the page

The following exception is raised:

Error while calling actor 'domwalker's method 'children' Permission denied to access property "jQuery300023229982312416421" protocol.js:1042:13

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We are trying to access a dead node somewhere and that is breaking the world.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

In this case the page is loading a Twitter widget and we recurse into the iframe checking each node for events. The Twitter widget has a jQuery event but because of CORS we have no access to the script, a Security exception is thrown and the world is broken.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a7bd654a9bd6076242eb2e927431c5f5cc2e85d

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e2f20af3f902ea65436bcfd288b3e075d6508f8

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1535661 - Fix CORS issues in Markup Panel r?pbro!

One change is in node.js::isScrollable() so I decided to assign this to you for review. Feel free to re-assign as you feel appropriate if you don't have time.

Try

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e2f20af3f902ea65436bcfd288b3e075d6508f8

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4641d251c208
Fix CORS issues in Markup Panel r=pbro

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/4641d251c208

Comment 8

[Pascal Chevrel:pascalc]

Mike, this was filed and marked as a P1 just before merge Day so it in 68. Would that be something we should uplift to 67 beta?

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

To be honest it is an edge case so lets leave it.

If we receive any reports we can always uplift to beta later.

Comment 10

[Cristian Fogel [:cfogel]]

As per the discussion with Mike on Slack website has changed.
Removing QE+ since preparing a TC for it would involve to much time investment.