Closed Bug 1535723 Opened 3 years ago Closed 3 years ago

Don't show inline attachments for bugs that have the keywords "hang", "assertion", or "crash"

Categories

(bugzilla.mozilla.org :: User Interface, enhancement, P2)

Production
enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: dholbert, Assigned: kohei.yoshino)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
Details | Review

RE the new "inline attachments" feature: could we please disable it for bugs that have the keywords "hang", "assertion", or "crash"?

Otherwise, any such open bugs with attached image-flavored testcases (e.g. SVG files) become unvisitable in Firefox, by definition. (At least, the hang/crash ones do; and the assertion ones potentially do in debug builds.)

Just as an example -- here's one bugzilla page which now (as of recently) is un-visitable in Firefox, due to us showing an inline preview of a known-to-hang-Firefox SVG testcase:
https://bugzilla.mozilla.org/show_bug.cgi?id=1297206

Component: Bug Creation/Editing → General

BTW: I know that I can turn off previews universally for my own bugzilla account, but that's not a great solution here.

I should be able to share bugzilla bug-report links (like the one in comment 0, for example) with other folks (e.g. my manager, a code reviewer, on IRC, etc) without worrying that I'm inadvertently about to take down their content process due to bugzilla auto-previewing the known-explodey attachments.

kohei, do you know if there's anything we can do here?

Flags: needinfo?(kohei.yoshino)

Yeah we can do this. Also I’ll provide a way to hide a specific image by tagging the comment, maybe with the new hide-attachment tag.

Assignee: nobody → kohei.yoshino
Blocks: 1472522
Status: NEW → ASSIGNED
Component: General → User Interface: Modal
Flags: needinfo?(kohei.yoshino)
Attached file GitHub Pull Request

We should fix this as soon as Monday.

Priority: -- → P2
Priority: P2 → P1

Inline images are now turned off by default as an interim measure until my PR is deployed.

Priority: P1 → P2
See Also: → 1538383

Merged to master.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

Note: I’ve updated my PR to hide all SVG images from inline preview (this bug) and attachment uploader (bug 1538383).

See Also: → 1542882
Component: User Interface: Modal → User Interface
You need to log in before you can comment on or make changes to this bug.