1535723 - Don't show inline attachments for bugs that have the keywords "hang", "assertion", or "crash"

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, enhancement, P2)

Description

[Daniel Holbert [:dholbert]]

RE the new "inline attachments" feature: could we please disable it for bugs that have the keywords "hang", "assertion", or "crash"?

Otherwise, any such open bugs with attached image-flavored testcases (e.g. SVG files) become unvisitable in Firefox, by definition. (At least, the hang/crash ones do; and the assertion ones potentially do in debug builds.)

Just as an example -- here's one bugzilla page which now (as of recently) is un-visitable in Firefox, due to us showing an inline preview of a known-to-hang-Firefox SVG testcase:
https://bugzilla.mozilla.org/show_bug.cgi?id=1297206

Comment 1

[Daniel Holbert [:dholbert]]

BTW: I know that I can turn off previews universally for my own bugzilla account, but that's not a great solution here.

I should be able to share bugzilla bug-report links (like the one in comment 0, for example) with other folks (e.g. my manager, a code reviewer, on IRC, etc) without worrying that I'm inadvertently about to take down their content process due to bugzilla auto-previewing the known-explodey attachments.

kohei, do you know if there's anything we can do here?

Comment 2

[Kohei Yoshino [:kohei]]

Yeah we can do this. Also I’ll provide a way to hide a specific image by tagging the comment, maybe with the new hide-attachment tag.

Comment 3

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request

Comment 4

[Kohei Yoshino [:kohei]]

We should fix this as soon as Monday.

Comment 5

[Kohei Yoshino [:kohei]]

Inline images are now turned off by default as an interim measure until my PR is deployed.

Comment 6

[Kohei Yoshino [:kohei]]

Merged to master.

Comment 7

[Kohei Yoshino [:kohei]]

Note: I’ve updated my PR to hide all SVG images from inline preview (this bug) and attachment uploader (bug 1538383).