1535732 - (VS2019) Officially support building with Visual Studio 2019

Status: VERIFIED WONTFIX

(Firefox Build System :: General, enhancement)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Release Candidate builds of Visual Studio 2019 are available since 2019-02-27.
General Availability build of Visual Studio 2019 will be released in 2019-04-02.

https://devblogs.microsoft.com/visualstudio/visual-studio-2019-release-candidate-rc-now-available/
https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes

Comment 1

[Nathan Froyd [:froydnj]]

We have dropped support for compiling with MSVC:

https://groups.google.com/d/msg/mozilla.dev.platform/me1ZMGgv6mI/u0xS5aapGQAJ

Comment 2

[Mike Hommey [:glandium]]

We still rely on MSVC, though, for headers and some tools, so if there are problems with those newer versions, please file specific bugs.

Comment 3

[TheQwertiest]

"We have dropped support for compiling with MSVC"
Does it mean that there will be no support for embedding SM (pre-built with clang) with MSVC? (like the linked bug with headers incompatibility)

Comment 4

[TheQwertiest]

formatting fix

We have dropped support for compiling with MSVC

Does it mean that there will be no support for embedding SM (pre-built with clang) with MSVC? (like the linked bug with headers incompatibility)

Comment 5

[TheQwertiest]

I will rephrase the question a bit:
Does it mean that there is NO support for embedding (pre-built) SM with ANY compiler other than clang?

Comment 6

[Nathan Froyd [:froydnj]]

Versions of Firefox that supported compiling with MSVC should work as pre-built binaries. Support for embedding with non-ESR versions is best-effort; we recommend that embedders use ESR SpiderMonkey when possible.

Comment 7

[TheQwertiest]

Fair enough, but the thing is that there is a WONT FIX label here, which means it won't be supported in upcoming ESR68 either.

WONT FIX means that "any incompatibilities that will appear because of changes in compilers or in SM headers (which will surely appear in time with probability of 100%) won't be ever fixed". So, to continue using SpiderMonkey (even from ESR branches) embedders will have to either use outdated compilers or use outdated SpiderMonkey, both of which are rather bleak options.

Comment 8

[TheQwertiest]

To avoid possible confusion (since it was brought up in IRC): I'm not talking about compiling SM (or any other part of FF), but rather building something by using only external SpiderMonkey headers (which is a common scenario for shared library usage).

Comment 9

[Gian-Carlo Pascutto [:gcp]]

We still rely on MSVC, though, for headers and some tools, so if there are problems with those newer versions, please file specific bugs.

There are problems with MSVC2017 now in the sense that downloading it is hidden behind a Microsoft account login portal and an extra "dev essentials" signup on Microsoft's site. But our build instructions still refer to it (https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites) and of course the download links there now point to MSVC2019.