Closed Bug 1535745 Opened 5 months ago Closed 5 months ago

Clean up enable/disable logic for the WebRender program cache

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

Right now we have two prefs: gfx.webrender.program-binary and gfx.webrender.program-binary-disk. The idea is that the program cache can be used with/without the extra step of persisting the cache to disk.

There are two problems with the first pref. First, it doesn't actually do anything, because we end up triggering lazy instantiation whenever we create a window [1]. Second, there's no need for the non-disk cache in a SharedGL world, and I'm skeptical that we'd ever ship a platform without SharedGL.

So I propose eliminating gfx.webrender.program-binary and using the program cache exclusively for disk serialization, which should make the code clearer.

[1] https://searchfox.org/mozilla-central/rev/f1c7ba91fad60bfea184006f3728dd6ac48c8e56/gfx/webrender_bindings/WebRenderAPI.cpp#77

Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7db995954db
Eliminate gfx.webrender.program-binary. r=sotaro
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → bobbyholley
You need to log in before you can comment on or make changes to this bug.