1535745 - Clean up enable/disable logic for the WebRender program cache

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Bobby Holley (:bholley)]

Right now we have two prefs: gfx.webrender.program-binary and gfx.webrender.program-binary-disk. The idea is that the program cache can be used with/without the extra step of persisting the cache to disk.

There are two problems with the first pref. First, it doesn't actually do anything, because we end up triggering lazy instantiation whenever we create a window [1]. Second, there's no need for the non-disk cache in a SharedGL world, and I'm skeptical that we'd ever ship a platform without SharedGL.

So I propose eliminating gfx.webrender.program-binary and using the program cache exclusively for disk serialization, which should make the code clearer.

[1] https://searchfox.org/mozilla-central/rev/f1c7ba91fad60bfea184006f3728dd6ac48c8e56/gfx/webrender_bindings/WebRenderAPI.cpp#77

Comment 1

[Bobby Holley (:bholley)]

Attachment: Bug 1535745 - Eliminate gfx.webrender.program-binary.

Comment 2

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=954737b86ecbc4930c87168c8db766b489838d71

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7db995954db
Eliminate gfx.webrender.program-binary. r=sotaro

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/a7db995954db