Closed Bug 1535797 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 15438 - Update RTCDataChannel bufferedamountlow implementation.

Categories

(Core :: WebRTC, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15438 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15438
Details from upstream follow.

Marina Ciocea <marinaciocea@chromium.org> wrote:

Update RTCDataChannel bufferedamountlow implementation.

Maintain bufferedamount value in blink layer. Increase bufferedamount on send
and decrease it on OnBufferedAmountChange updates from webrtc layer. Fire
bufferedamountlow when bufferedamount goes below bufferedamountlowthreshold.

This change builds upon the corresponding webrtc change:
https://webrtc-review.googlesource.com/c/src/+/123237

Design doc: http://doc/1lorHBn-GMn5U0T0RQANxrsW0pXhw8XGZM-xZyVUOW90
Standard: https://w3c.github.io/webrtc-pc/#event-datachannel-bufferedamountlow

Bug: 878682
Change-Id: Ifebc79f71f924ecb5cedce1c94e18440663337f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474764
Commit-Queue: Marina Ciocea \<marinaciocea@chromium.org>
Reviewed-by: Henrik Boström \<hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#639846}

Component: web-platform-tests → WebRTC
Product: Testing → Core
Ran 1 tests


Tests that are disabled for instability:
/webrtc/RTCDataChannel-bufferedAmount.html
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b779595e781
[wpt PR 15438] - Update RTCDataChannel bufferedamountlow implementation., a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.