Closed Bug 1535850 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 15790 - Use matching sample rate for the context as for the reference file

Categories

(Core :: Web Audio, enhancement, P4)

Product:
Core
Component:
Web Audio
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15790 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15790
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:

Use matching sample rate for the context as for the reference file

The reference file has a certain sample rate. Use the same for the
context to reduce the amount of resampling that might be required.

Regenerated the webm-decode-expected.wave file with the fixed sample rate. This also
changed the SNR slightly, so update the SNR test accordingly. Also manually compared
the new and old files. These differ by at most 1 LSB (16-bit).

Bug: 940970
Change-Id: I979bbeb512c36d7e2eb4cba85550fa4177b8aabd

Reviewed-on: https://chromium-review.googlesource.com/1516723
WPT-Export-Revision: 69c8458fa5096d60ab40139ea07296c000069b88

Component: web-platform-tests → Web Audio
Product: Testing → Core
Ran 1 tests and 3 subtests OK : 1 PASS : 2 FAIL : 1
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/350bb00db229 [wpt PR 15790] - Use matching sample rate for the context as for the reference file, a=testonly

https://hg.mozilla.org/mozilla-central/rev/350bb00db229

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.