1536059 - <checkbox> accesskeys aren't visible anymore

Status: RESOLVED FIXED

(Core :: XUL, defect, P1)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1455433 +++

Bug 1455433 comment 55:
"In Tools > Preferences on labels of checkboxes, the accesskey's aren't visible anymore. I noticed this in Thunderbird 67.0a1, but the same holds for Firefox 67.0a1..."

Comment 1

[alexander :surkov (:asurkov)]

Attachment: Bug 1536059 - <checkbox> accesskeys aren't visible anymore

Comment 2

[alexander :surkov (:asurkov)]

(In reply to alexander :surkov (:asurkov) from comment #1)

Created attachment 9051743 [details]
Bug 1536059 - <checkbox> accesskeys aren't visible anymore

if we set accesskey before label, then label.formatAccessKey fails since there's no text yet. Ideally, we should reformat accesskey whenever label text is changed I'd say, but it how it works from the beginning.

Comment 3

[alexander :surkov (:asurkov)]

Attachment: Bug 1536059 - change checkbox attribute inheritance order to make label accesskey formatting work, r=bgrins

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e58ba9d9dd7
change checkbox attribute inheritance order to make label accesskey formatting work, r=bgrins

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/9e58ba9d9dd7

Comment 6

[Pascal Chevrel:pascalc]

P1 bug and comment #0 indicates that it regressed in 67. Alexander once this has been verified in Nightly, could you nominate your patch for uplifting to beta? Thanks!

Comment 7

[alexander :surkov (:asurkov)]

Comment on attachment 9051751 [details]
Bug 1536059 - change checkbox attribute inheritance order to make label accesskey formatting work, r=bgrins

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1455433
• User impact if declined: accesskeys are not reflected in UI in about:preferences
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): one line fix: changing attribute inheritance order in a XUL checkbox
• String changes made/needed: no

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9051751 [details]
Bug 1536059 - change checkbox attribute inheritance order to make label accesskey formatting work, r=bgrins

Micro-patch fixing a P1 a11y regression introduced in 67, uplift approved for beta 4. Thanks

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Could we add a test for this?

Comment 10

[alexander :surkov (:asurkov)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)

Could we add a test for this?

not sure if it's worth it, xul:checkboxes will be likely removed from preferences in foreseeable future in bug 1532651.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Fair enough!

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/90baa49d098a