Closed Bug 1536059 Opened 10 months ago Closed 10 months ago

<checkbox> accesskeys aren't visible anymore

Categories

(Core :: XUL, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 + fixed
firefox68 --- fixed

People

(Reporter: mkmelin, Assigned: surkov)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1455433 +++

Bug 1455433 comment 55:
"In Tools > Preferences on labels of checkboxes, the accesskey's aren't visible anymore. I noticed this in Thunderbird 67.0a1, but the same holds for Firefox 67.0a1..."

(In reply to alexander :surkov (:asurkov) from comment #1)

Created attachment 9051743 [details]
Bug 1536059 - <checkbox> accesskeys aren't visible anymore

if we set accesskey before label, then label.formatAccessKey fails since there's no text yet. Ideally, we should reformat accesskey whenever label text is changed I'd say, but it how it works from the beginning.

Attachment #9051751 - Attachment is obsolete: true
Attachment #9051751 - Attachment is obsolete: false
Attachment #9051743 - Attachment is obsolete: true
Priority: -- → P1
Assignee: nobody → surkov.alexander
Pushed by asurkov@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e58ba9d9dd7
change checkbox attribute inheritance order to make label accesskey formatting work, r=bgrins
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

P1 bug and comment #0 indicates that it regressed in 67. Alexander once this has been verified in Nightly, could you nominate your patch for uplifting to beta? Thanks!

Flags: needinfo?(surkov.alexander)

Comment on attachment 9051751 [details]
Bug 1536059 - change checkbox attribute inheritance order to make label accesskey formatting work, r=bgrins

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1455433
  • User impact if declined: accesskeys are not reflected in UI in about:preferences
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): one line fix: changing attribute inheritance order in a XUL checkbox
  • String changes made/needed: no
Flags: needinfo?(surkov.alexander)
Attachment #9051751 - Flags: approval-mozilla-beta?

Comment on attachment 9051751 [details]
Bug 1536059 - change checkbox attribute inheritance order to make label accesskey formatting work, r=bgrins

Micro-patch fixing a P1 a11y regression introduced in 67, uplift approved for beta 4. Thanks

Attachment #9051751 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Could we add a test for this?

Flags: needinfo?(surkov.alexander)
Flags: in-testsuite?

(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)

Could we add a test for this?

not sure if it's worth it, xul:checkboxes will be likely removed from preferences in foreseeable future in bug 1532651.

Flags: needinfo?(surkov.alexander)

Fair enough!

Flags: in-testsuite? → in-testsuite-
You need to log in before you can comment on or make changes to this bug.