1536062 - Dead code shouldn't abort compilation with OOM

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

In WasmIonCompile.cpp, the rule is that if we're in dead code, then we should return true. Returning false indicates an error, and since no explicit error message is attached, this is understood by the compiler to be an out-of-memory error.

The only real-world pain point this might cause and that I can think of is for fuzzers which will fail more than actually needed (and manual testers trying to reduce test cases).

I've checked all the uses of inDeadCode and found a few of them which were incorrect. Patch with tests incoming.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1536062: Make sure that dead-code doesn't prevent ion compilation of wasm modules; r?lth

This also fixes-up a few places in text-to-binary where no error messages were
generated, resulting in incorrect out-of-memory messages.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6b8fe318656
Make sure that dead-code doesn't prevent ion compilation of wasm modules; r=lth

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/c6b8fe318656