1536137 - RDD processes (and anything else that does memory reporting) will call getrusage

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Jed Davis [:jld] (on leave until 08-31)]

Found while trying to see if bug 1536127 would reproduce. STR: flip the AV1/RDD prefs, load an AV1 video, and then do a memory report. getrusage is called from here and it's not allowed (yet).

This (and bug 1536127) were missed because GMP doesn't do memory reporting (so the common policy doesn't cover it), and while we have tests for memory reporting and AV1 separately, we apparently don't have even a smoke test for memory reporting combined with AV1.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Attachment: Bug 1536137 - Add getrusage to RDD policy. r?jld

Depends on D24190

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42b734a0a83d
Add getrusage to RDD policy. r=jld

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/42b734a0a83d

Comment 4

[Daniel Cicas [:dcicas], Release QA]

Hello,

I'm trying to reproduce this issue can you please tell me what are the AV1/RDD prefs and what value should they have? Also am I mistaken in thinking that the memory report refers to the one done using the web developer tools (memory tab)?

Comment 5

[Jed Davis [:jld] (on leave until 08-31)]

(In reply to Daniel Cicas [:dcicas], Release QA from comment #4)

I'm trying to reproduce this issue can you please tell me what are the AV1/RDD prefs and what value should they have? Also am I mistaken in thinking that the memory report refers to the one done using the web developer tools (memory tab)?

The prefs are media.rdd-process.enabled and media.av1.enabled, but I think they're on by default now. The memory report I was doing was through about:memory (the “Measure” button).