Closed
Bug 1536169
Opened 5 years ago
Closed 5 years ago
The Picture-in-Picture window has too much whitespace on Windows
Categories
(Toolkit :: Video/Audio Controls, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(3 files)
Before patch
This is because we're using the width and height window features to calculate the dimensions, and not outerWidth and outerHeight (for some reason, the window seems to have some minimum chrome height that it's adding on top of the height that's being supplied).
Setting the outerWidth and outerHeight values fixes this.
|
Assignee | |
Comment 1•5 years ago
|
||
There also seem to be cases where there's a pixel too much whitespace because we use Math.floor after applying the max-size clamping with aspect ratio. Using Math.round instead appears to fix this.
Summary: The Picture-in-Picture window has too much vertical whitespace on Windows → The Picture-in-Picture window has too much whitespace on Windows
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/93efe527cad2 Get rid of extra whitespace around Picture-in-Picture player. r=JSON_voorhees
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
||
Updated•5 years ago
|
QA Whiteboard: [qa-68b-p2]
You need to log in
before you can comment on or make changes to this bug.
Description
•