1536220 - Enable ARM64 Ion in-browser

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P2)

Description

[Sean Stangl [:sstangl]]

We were asked to wait for 68 to toggle on the pref. 68 is here, toggle away!

Comment 1

[Sean Stangl [:sstangl]]

Attachment: Bug 1536220 - Enable IonMonkey on ARM64 in-browser. r=nbp

Enable IonMonkey on ARM64 in-browser.

Comment 2

[Sean Stangl [:sstangl]]

Trychooser does not support running any browser tests, as far as I can tell.

Comment 3

[Mike Conca [:mconca]]

\o/ Woot! Ion for ARM64 by default!

Sean, does this patch toggle it for both desktop (Windows) and mobile (Android)?

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Mike Conca [:mconca] from comment #3)

Sean, does this patch toggle it for both desktop (Windows) and mobile (Android)?

Yes

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebf98069b0fb
Enable IonMonkey on ARM64 in-browser. r=nbp

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/ebf98069b0fb

Comment 7

[Ionuț Goldan [:igoldan]]

Noticed a bit perf improvement:

== Change summary for alert #19981 (as of Tue, 19 Mar 2019 23:04:07 GMT) ==

Improvements:

16% raptor-speedometer-geckoview android-hw-p2-8-0-android-aarch64 opt 18.24 -> 21.11

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19981

Comment 8

[Sean Stangl [:sstangl]]

Comment on attachment 9051814 [details]
Bug 1536220 - Enable IonMonkey on ARM64 in-browser. r=nbp

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: None
• User impact if declined: ARM64 will remain disabled on 67. (We've been requested by management to enable it to get better coverage.)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1529559
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): The change enables an entire JIT on ARM64, and we expect this to increase the number of crashes. Beta uplift was specifically requested so that we could get broader testing of this feature, because the Android Nightly userbase is extremely small.

The good news is that if this proves too crashy for our tastes, reverting this single patch is sufficient to plug up the issue once more.

• String changes made/needed:

Comment 9

[Chris Peterson [:cpeterson]]

Beta uplift was specifically requested so that we could get broader testing of this feature, because the Android Nightly userbase is extremely small.

Sean, are you proposing we ship ARM64 in Fennec 67 Release or just enable it in Fennec 67 Beta to get more pre-release testing (before shipping in Fennec 68 Release)?

If you want to ship ARM64 builds to Fennec Beta users, Releng will to change their release automation scripts to upload ARM64 Fennec Beta builds to the Google Play Store (like bug 1520261).

Comment 10

[Sean Stangl [:sstangl]]

Chris, please check with Steven de Tar, but my understanding is that the plan is to land for release. Based on how it does in Beta, we would back it out if it doesn't fare well, but based on Nightly it's expected to hold up.

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9051814 [details]
Bug 1536220 - Enable IonMonkey on ARM64 in-browser. r=nbp

Uplift approved for 67 beta 9.

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/44f1f623790f