1536264 - Some <option> CSS properties should be preserved while the option is active (was: Custom styling of <option> elements in a <select> is lost while they are active)

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Jonathan Kew [:jfkthame]]

Attachment: testcase

Open the <select> menu in the testcase, and move the mouse up and down to different options within it. Note how the custom styling of options is "forgotten" while they are active/highlighted.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Yeah, I guess the color / background change is intentional, but the other properties should probably be kept. Will take a look this week.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1536264 - Only reset color / background / text-shadow for active options. r=jaws,mconley

Otherwise you see font changes when hovering, which is not really desirable.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de836d015f32
Only reset color / background / text-shadow for active options. r=jaws

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset de836d015f32 (Bug 1536264) for bc failures at browser_selectpopup_colors.js.

Backout: https://hg.mozilla.org/integration/autoland/rev/13b6a236827101be0971589f59751fcfc8182dc7

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=de836d015f32a8a4fe64bb14c75679a9e1a7f7a2&selectedJob=235076711

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=235076711&repo=autoland&lineNumber=3905

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Ouch, I always forget that these are disabled on Linux....

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/104d3e54d7ab
Only reset color / background / text-shadow for active options. r=jaws

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/104d3e54d7ab

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9052157 [details]
Bug 1536264 - Only reset color / background / text-shadow for active options. r=jaws,mconley

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1375476
• User impact if declined: Some <option> elements with custom font may look jumpy when hovering.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a relatively-simple patch.
• String changes made/needed: none

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9052157 [details]
Bug 1536264 - Only reset color / background / text-shadow for active options. r=jaws,mconley

Safe patch already verified on nightly and a follow up for the fix for bug 1375476 landed in the 67 cycle which fixed a notable CSS support regression caused by e10s, approved for beta 5, thanks.

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9d77f46fc075

Comment 11

[Cristian Craciun]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:67.0) Gecko/20100101 Firefox/67.0
Build ID: 20190325125126

Verified as fixed on the latest Nightly build and on the latest Beta build.