153629 - Remember query options contains invalid html

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Jouni Heikniemi]

bbaetz in bug 150776: "We have nested tables, and a <p> arround one of them, and..."

So we do. The radiobutton group with run/remember/load/etc. options really has
some horrible and invalid HTML. I'll take a look at this soon.

Comment 1

[Jouni Heikniemi]

Attachment: v1

Make the html validate and remove the unnecessary table. The html code
structure of this solution is fairly close to the 2.14.2 old query page model,
actually...

Comment 2

[Jouni Heikniemi]

Attachment: v1 in -uw

Timeless wanted a -uw version of the patch, so here goes. Review the one you
consider more readable, I don't care.

Comment 3

[Christian Reis]

Comment on attachment 88808 [details] [diff] [review]
v1 in -uw

>+   <input type="radio" name="cmdtype" value="asdefault"> Remember this as my default query
>+   <input type="radio" name="cmdtype" value="asnamed"> Remember this query, and name it: 
>       <input type="text" name="newqueryname">
>       <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<input type="checkbox" name="tofooter" value="1">
>           and put it in my page footer

It wouldn't hurt to wrap these lines, but apart from that, r=kiko.

Comment 4

[Jouni Heikniemi]

Attachment: v2: review fixes

kiko's line length nits fixed.

Comment 5

[Jouni Heikniemi]

Attachment: v2 in -uw

v2 in -uw format

Comment 6

[Jouni Heikniemi]

Comment on attachment 88813 [details] [diff] [review]
v2: review fixes

Assuming 2xr=kiko per discussion on IRC.

Comment 7

[Jouni Heikniemi]

Into trunk and branch:

Checking in knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/knob.html.tmpl,v 
<--  knob.html.tmpl
new revision: 1.4; previous revision: 1.3
done

Checking in knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/knob.html.tmpl,v 
<--  knob.html.tmpl
new revision: 1.2.2.2; previous revision: 1.2.2.1
done