Closed Bug 153629 Opened 22 years ago Closed 22 years ago
Remember query options contains invalid html
bbaetz in bug 150776: "We have nested tables, and a <p> arround one of them, and..." So we do. The radiobutton group with run/remember/load/etc. options really has some horrible and invalid HTML. I'll take a look at this soon.
Make the html validate and remove the unnecessary table. The html code structure of this solution is fairly close to the 2.14.2 old query page model, actually...
Timeless wanted a -uw version of the patch, so here goes. Review the one you consider more readable, I don't care.
Comment on attachment 88808 [details] [diff] [review] v1 in -uw >+ <input type="radio" name="cmdtype" value="asdefault"> Remember this as my default query >+ <input type="radio" name="cmdtype" value="asnamed"> Remember this query, and name it: > <input type="text" name="newqueryname"> > <br> <input type="checkbox" name="tofooter" value="1"> > and put it in my page footer It wouldn't hurt to wrap these lines, but apart from that, r=kiko.
Attachment #88808 - Flags: review+
kiko's line length nits fixed.
Attachment #88806 - Attachment is obsolete: true
v2 in -uw format
Attachment #88808 - Attachment is obsolete: true
Comment on attachment 88813 [details] [diff] [review] v2: review fixes Assuming 2xr=kiko per discussion on IRC.
Attachment #88813 - Flags: review+
Into trunk and branch: Checking in knob.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/search/knob.html.tmpl,v <-- knob.html.tmpl new revision: 1.4; previous revision: 1.3 done Checking in knob.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/search/knob.html.tmpl,v <-- knob.html.tmpl new revision: 220.127.116.11; previous revision: 18.104.22.168 done
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.