If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remember query options contains invalid html

RESOLVED FIXED in Bugzilla 2.16

Status

()

Bugzilla
Query/Bug List
--
minor
RESOLVED FIXED
16 years ago
5 years ago

People

(Reporter: Jouni Heikniemi, Assigned: Jouni Heikniemi)

Tracking

({polish, regression})

2.16
Bugzilla 2.16
polish, regression

Details

(URL)

Attachments

(2 attachments, 2 obsolete attachments)

4.96 KB, patch
Jouni Heikniemi
: review+
Jouni Heikniemi
: review+
Details | Diff | Splinter Review
2.96 KB, patch
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
bbaetz in bug 150776: "We have nested tables, and a <p> arround one of them, and..."

So we do. The radiobutton group with run/remember/load/etc. options really has
some horrible and invalid HTML. I'll take a look at this soon.
(Assignee)

Updated

16 years ago
Severity: normal → minor
Status: NEW → ASSIGNED
Keywords: polish, regression
Target Milestone: --- → Bugzilla 2.16
Version: unspecified → 2.16
(Assignee)

Updated

16 years ago
(Assignee)

Comment 1

16 years ago
Created attachment 88806 [details] [diff] [review]
v1

Make the html validate and remove the unnecessary table. The html code
structure of this solution is fairly close to the 2.14.2 old query page model,
actually...
(Assignee)

Comment 2

16 years ago
Created attachment 88808 [details] [diff] [review]
v1 in -uw

Timeless wanted a -uw version of the patch, so here goes. Review the one you
consider more readable, I don't care.

Comment 3

16 years ago
Comment on attachment 88808 [details] [diff] [review]
v1 in -uw

>+   <input type="radio" name="cmdtype" value="asdefault"> Remember this as my default query
>+   <input type="radio" name="cmdtype" value="asnamed"> Remember this query, and name it: 
>       <input type="text" name="newqueryname">
>       <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<input type="checkbox" name="tofooter" value="1">
>           and put it in my page footer

It wouldn't hurt to wrap these lines, but apart from that, r=kiko.
Attachment #88808 - Flags: review+
(Assignee)

Comment 4

16 years ago
Created attachment 88813 [details] [diff] [review]
v2: review fixes

kiko's line length nits fixed.
Attachment #88806 - Attachment is obsolete: true
(Assignee)

Comment 5

16 years ago
Created attachment 88814 [details] [diff] [review]
v2 in -uw

v2 in -uw format
Attachment #88808 - Attachment is obsolete: true
(Assignee)

Comment 6

16 years ago
Comment on attachment 88813 [details] [diff] [review]
v2: review fixes

Assuming 2xr=kiko per discussion on IRC.
Attachment #88813 - Flags: review+
(Assignee)

Comment 7

16 years ago
Into trunk and branch:

Checking in knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/knob.html.tmpl,v 
<--  knob.html.tmpl
new revision: 1.4; previous revision: 1.3
done

Checking in knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/knob.html.tmpl,v 
<--  knob.html.tmpl
new revision: 1.2.2.2; previous revision: 1.2.2.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.