Closed Bug 153629 Opened 21 years ago Closed 21 years ago

Remember query options contains invalid html

Categories

(Bugzilla :: Query/Bug List, defect)

2.16
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 2.16

People

(Reporter: jouni, Assigned: jouni)

References

()

Details

(Keywords: polish, regression)

Attachments

(2 files, 2 obsolete files)

bbaetz in bug 150776: "We have nested tables, and a <p> arround one of them, and..."

So we do. The radiobutton group with run/remember/load/etc. options really has
some horrible and invalid HTML. I'll take a look at this soon.
Severity: normal → minor
Status: NEW → ASSIGNED
Keywords: polish, regression
Target Milestone: --- → Bugzilla 2.16
Version: unspecified → 2.16
Attached patch v1 (obsolete) — Splinter Review
Make the html validate and remove the unnecessary table. The html code
structure of this solution is fairly close to the 2.14.2 old query page model,
actually...
Attached patch v1 in -uw (obsolete) — Splinter Review
Timeless wanted a -uw version of the patch, so here goes. Review the one you
consider more readable, I don't care.
Comment on attachment 88808 [details] [diff] [review]
v1 in -uw

>+   <input type="radio" name="cmdtype" value="asdefault"> Remember this as my default query
>+   <input type="radio" name="cmdtype" value="asnamed"> Remember this query, and name it: 
>       <input type="text" name="newqueryname">
>       <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<input type="checkbox" name="tofooter" value="1">
>           and put it in my page footer

It wouldn't hurt to wrap these lines, but apart from that, r=kiko.
Attachment #88808 - Flags: review+
Attached patch v2: review fixesSplinter Review
kiko's line length nits fixed.
Attachment #88806 - Attachment is obsolete: true
Attached patch v2 in -uwSplinter Review
v2 in -uw format
Attachment #88808 - Attachment is obsolete: true
Comment on attachment 88813 [details] [diff] [review]
v2: review fixes

Assuming 2xr=kiko per discussion on IRC.
Attachment #88813 - Flags: review+
Into trunk and branch:

Checking in knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/knob.html.tmpl,v 
<--  knob.html.tmpl
new revision: 1.4; previous revision: 1.3
done

Checking in knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/knob.html.tmpl,v 
<--  knob.html.tmpl
new revision: 1.2.2.2; previous revision: 1.2.2.1
done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.